Skip to content

HW1 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

HW1 #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29e7344
HW1
Jun 28, 2019
0771849
HW1
Jul 2, 2019
b5656c6
fix
Jul 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 126 additions & 0 deletions Aleksandr Zorin/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,126 @@
body {
background-image: url(../img/background.jpg);
background-position: center center;
background-repeat: no-repeat;
background-attachment: fixed;
background-size: cover;
font-family: 'Dosis', sans-serif;
margin: 0;
}

p {
margin: 0;
}

.weatherWidget {
margin-top: 100px;
display: flex;
justify-content: center;
flex-wrap: wrap;
}

.location {
background-image: url(../img/city.jpg);
background-size: cover;
width: 500px;
border-radius: 10px 0px 0px 10px;
box-shadow: 0px 0px 100px 1px black;
Copy link

@aleksandrbelik aleksandrbelik Jul 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zorin-Alex It's better to set border-radius and box-shadow on the whole .weatherWidget. It's easier and will be managed more simpler

Copy link
Author

@Zorin-Alex Zorin-Alex Jul 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.weatherWidget is a flex-container with full page width,so border-radius for it wouldn't make any sense for his child-elements

display: flex;
flex-direction: column;
overflow: hidden;
}

.information {
box-sizing: border-box;
width: 500px;
padding-left: 50px;
padding-right: 50px;
background-color: #FFFFFF;
border-radius: 0px 10px 10px 0px;
box-shadow: 0px 0px 50px 1px black;
display: flex;
flex-direction: column;
}

.temp {
padding-top: 40px;
padding-bottom: 40px;
font-size: 100pt;
font-weight: 200;
color: #8E4140;
text-align: center;
border-bottom: 2px solid #8E4140;
}

.graph {
padding-top: 20px;
padding-bottom: 20px;
border-bottom: 2px solid #8E4140;
}

.days {
padding-top: 40px;
padding-bottom: 20px;
display: flex;
justify-content: space-around;
}

.weatherType {
background: rgba(46,28,37,0.89);
font-size: 60pt;
line-height: 1.5;
font-weight: 200;
text-align: center;
color: white;
}

.today {
background: rgba(119,25,33,0.89);
font-size: 20pt;
font-weight: 300;
text-align: center;
color: white;
padding-top: 40px;
padding-bottom: 40px;
}

.weatherTypeLogo {
box-sizing: content-box;
height: 100%;
text-align: center;
padding-top: 85px;
padding-bottom: 84px;
}

.wrapper {
text-align: center
}

.day {
font-size: 16pt;
font-weight: 40;
line-height: 2;
text-align: center
}

.weekdayInformation {
text-align: center;
padding-left: 20px;
padding-right: 20px;
color: #8E4140;
}

.nightTimeTemp {
color: black;
}

.dayWeatherLogo {
padding-left: 15px;
padding-right: 15px;
Copy link

@aleksandrbelik aleksandrbelik Jul 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zorin-Alex Please look at padding property
You can set in one line padding: 0 15px

}

.weekday {
border-bottom: 2px solid #8E4140;
padding-top: 15px;
padding-bottom: 10px;
Copy link

@aleksandrbelik aleksandrbelik Jul 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zorin-Alex Please look at padding property
You can set it in one line padding: 15px 0 10px 0

}
Binary file added Aleksandr Zorin/img/background.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Aleksandr Zorin/img/city.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Aleksandr Zorin/img/weather/cloudy.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Aleksandr Zorin/img/weather/sunny-big.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Aleksandr Zorin/img/weather/sunny.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
57 changes: 57 additions & 0 deletions Aleksandr Zorin/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
<!doctype html>
<html>
<head>
<meta charset="utf-8">
<title>Tokyo</title>
<link rel="stylesheet" type="text/css" href="css/style.css" />
<link href="https://fonts.googleapis.com/css?family=Dosis:200,300,400&display=swap" rel="stylesheet">
</head>

<body>
<article class="weatherWidget">
<div class="location">
<div class="weatherTypeLogo"><img src="img/weather/sunny-big.png" width="50%"></div>
Copy link

@aleksandrbelik aleksandrbelik Jul 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zorin-Alex It's better to move width of image to css

<div class="weatherType">Sunny</div>
<div class="today">Tokyo - Wednesday, July 31</div>
</div>
<div class="information">
<div class="temp">
28 &deg;C
</div>
<div class="graph">
<svg width="100%"viewBox="0 0 400 150">
<line x1="20" y1="10" x2="80" y2="130" stroke="#8E4140" stroke-width = "2"/>
<line x1="80" y1="130" x2="140" y2="70" stroke="#8E4140" stroke-width = "2"/>
<line x1="140" y1="70" x2="200" y2="30" stroke="#8E4140" stroke-width = "2"/>
<line x1="200" y1="30" x2="260" y2="130" stroke="#8E4140" stroke-width = "2"/>
<line x1="260" y1="130" x2="320" y2="10" stroke="#8E4140" stroke-width = "2"/>
<line x1="320" y1="10" x2="380" y2="70" stroke="#8E4140" stroke-width = "2"/>

<circle cx="20" cy="10" r="4" stroke="#8E4140" stroke-width="3" fill ="white"/>
<circle cx="80" cy="130" r="4" stroke="#8E4140" stroke-width="3" fill ="white"/>
<circle cx="140" cy="70" r="4" stroke="#8E4140" stroke-width="3" fill ="white"/>
<circle cx="200" cy="30" r="4" stroke="#8E4140" stroke-width="3" fill ="white"/>
<circle cx="260" cy="130" r="4" stroke="#8E4140" stroke-width="3" fill ="white"/>
<circle cx="320" cy="10" r="4" stroke="#8E4140" stroke-width="3" fill ="white"/>
<circle cx="380" cy="70" r="4" stroke="#8E4140" stroke-width="3" fill ="white"/>
</svg>
</div>
<div class="days">
<div class="day">
<img class="dayWeatherLogo" src="img/weather/sunny.png" width="70%">
<div class="weekdayInformation"><p class="weekday">Thu</p><p class="dayTimeTemp">28 &deg;C</p><p class="nightTimeTemp">18 &deg;C</p></div>
</div>
<div class="day">
<img class="dayWeatherLogo" src="img/weather/cloudy.png" width="70%">
<div class="weekdayInformation"><p class="weekday">Fri</p><p class="dayTimeTemp">22 &deg;C</p><p class="nightTimeTemp">20 &deg;C</p></div>
</div>
<div class="day">
<img class="dayWeatherLogo" src="img/weather/cloudy.png" width="70%">
Copy link

@aleksandrbelik aleksandrbelik Jul 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zorin-Alex same case with width for the . dayWeatherLogo. It's much more better to set width property in css

<div class="weekdayInformation"><p class="weekday">Sat</p><p class="dayTimeTemp">30 &deg;C</p><p class="nightTimeTemp">27 &deg;C</p></div>
</div>

</div>
</article>

</body>
</html>