Skip to content

Alina Firsova #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Alina Firsova #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c702166
AlinaFirsova
Jun 30, 2019
9c29559
upgrade
Jul 13, 2019
c141afa
update
Jul 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions Alina Firsova/Homework_1_Firsova.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<!DOCTYPE HTML>
<html>
<head>
<meta charset="utf-8">
<title>Cubes</title>
<link rel="stylesheet" type="text/css" href="style.css">
</head>
<body>
<div class="background"></div>
<div class="container">
Copy link

@aleksandrbelik aleksandrbelik Jul 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlinaFirsova try to use appropriate semantic tags in code


<div class="row">
<div class="chicago"><div class="element"><img src="img\rainy.png"></div><div class="element">CHICAGO / 23°</div></div>
<div class="seattle"><div class="element"><img src="img\fog.png"></div><div class="element">SEATTLE / 34°</div></div>
<div class="brooklyn"><div class="element"><img src="img\sun_cloud.png"></div><div class="element">BROOKLYN / 55°</div></div>
</div>

<div class="row">
<div class="portland">
<div class="element"><img src="img\sun_rainy.png"></div>
<div class="element">PORTLAND / 27°</div></div>
<div class="week_top">
<div class="element"><img src="img\half_moon.png"></div>
<div class="week_bottom">
<div class="week">
<div class="day"><div class="name">MON</div><div class="image-div"><img height="80%" src="img\rainy_small.png"></div><div class="value">22°</div></div>
<div class="day"><div class="name">TUE</div><div class="image-div"><img height="80%" src="img\rainy_small.png"></div><div class="value">19°</div></div>
<div class="day"><div class="name">WEN</div><div class="image-div"><img height="75%" src="img\cloud_small.png"></div><div class="value">18°</div></div>
Copy link

@aleksandrbelik aleksandrbelik Jul 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlinaFirsova It's better to set any style property in css. So you can move height property to css with appropriate class name

<div class="day"><div class="name">THU</div><div class="image-sun-div"><img src="img\sun_cloud_small.png"></div><div class="value">14°</div></div>
Copy link

@aleksandrbelik aleksandrbelik Jul 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlinaFirsova There is modificator approach. You can still set .image-divto img wrapper and add modificator class. So it can look like .image-div .image-sun-div
And that's mean that you don't need to duplicate css styles. In this case you won't duplicate height style
.image-div {
height: 25px;
}

.image-sun-div {
position: relative;
}

</div>
</div>
</div>
<div class="san_jose"><div class="element"><img src="img\cloud.png"></div><div class="element">SAN JOSE / 47°</div></div>
</div>
</div>
</body>
</html>


Binary file added Alina Firsova/img/Thumbs.db
View file
Open in desktop
Binary file not shown.
Binary file added Alina Firsova/img/back_main.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Alina Firsova/img/brooklyn_back.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Alina Firsova/img/chicago_back.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Alina Firsova/img/cloud.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Alina Firsova/img/cloud_small.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Alina Firsova/img/fog.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Alina Firsova/img/half_moon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Alina Firsova/img/portland_back.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Alina Firsova/img/rainy.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Alina Firsova/img/rainy_small.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Alina Firsova/img/san_jose_back.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Alina Firsova/img/seattle_back.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Alina Firsova/img/sun_cloud.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Alina Firsova/img/sun_cloud_small.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Alina Firsova/img/sun_rainy.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Alina Firsova/img/week_back1.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Alina Firsova/img/week_back2.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
186 changes: 186 additions & 0 deletions Alina Firsova/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,186 @@
body, html {
height: 100%;
margin: 0;
}

.span{
Copy link

@aleksandrbelik aleksandrbelik Jul 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlinaFirsova Can't find any .span in code. Please remove unnecessary styles

font-size: 10px;
font-family: Francois One, bold;
color: white;
}
p{
Copy link

@aleksandrbelik aleksandrbelik Jul 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlinaFirsova Can't find any paragraph tag in code. Please remove unnecessary styles


font-family: Francois One, bold;
color: white;
}



.background{
background-image:url(img/back_main.png);
background-repeat: no-repeat;
background-size: cover;
background-position: center;
height: 100%;

}

.week{
display: flex;
justify-content: space-around;
align-items: center;
padding: 20px 15px 0 15px;

}

.day{
color: white;
font-weight: bold;
font-family:Helvetica, monospace;
display: flex;
flex-direction:column;
justify-content:space-between;
font-size: 12px;
text-align: center;




}

.name {
padding-bottom: 10px;
}

.image-div {
height: 25px;
}

.image-sun-div {
height: 25px;
position: relative;
}

.image-sun-div img {
Copy link

@aleksandrbelik aleksandrbelik Jul 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlinaFirsova Please don't use tag names in styles, it's better to add class name to img

position: absolute;
top: -3px;
left: 0;
}

.value {
padding-top: 3px;
}

.container {
top: 0;
bottom: 0;
left: 0;
right: 0;
margin: auto;
position: absolute;
width: 615px;
height: 410px;
display: flex;
flex-wrap: wrap;
justify-content: center;
align-items: center;
box-shadow: 0 0 70px rgba(0,0,0,0.9)
}

.row{
display: flex;
flex-wrap:wrap;
flex-direction:row;
}

.chicago{
background-image:url(img/chicago_back.png);
Copy link

@aleksandrbelik aleksandrbelik Jul 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlinaFirsova It's much bore better to use background color property instead of colorized image

background-repeat: no-repeat;
width: 205px;
height: 205px;
display: flex;
justify-content: center;
align-items: center;
flex-direction:column;
Copy link

@aleksandrbelik aleksandrbelik Jul 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlinaFirsova Please try to avoid of duplicating of styles. So you can add common class for blocks and set it each block. For example
.block {
width: 205px;
height: 205px;
display: flex;
justify-content: center;
align-items: center;
flex-direction:column;
}
.chicago {
background-color: // colo that you need
}

CHICAGO / 23°


}
.seattle{

background-image:url(img/seattle_back.png);
background-repeat: no-repeat;
background-size: contain;
width: 205px;
height: 205px;
display: flex;
justify-content: center;
align-items: center;
flex-direction:column;
}
.brooklyn{

background-image:url(img/brooklyn_back.png);
background-repeat: no-repeat;
background-size: contain;
width: 205px;
height: 205px;
display: flex;
justify-content: center;
align-items: center;
flex-direction:column;
}
.portland{

background-image:url(img/portland_back.png);
background-repeat: no-repeat;
width: 205px;
height: 205px;
display: flex;
justify-content: center;
align-items: center;
flex-direction:column;

}
.week_top{
background-image:url(img/week_back1.png);
background-repeat: no-repeat;
background-size: contain;
width: 205px;
height: 205px;
height: 205px;
display: flex;
justify-content: flex-end;
align-items: center;
flex-direction:column;
}

.week_bottom{
background-image:url(img/week_back2.png);
background-repeat: no-repeat;
background-size: contain;
width: 205px;
height: 99px;

}

.san_jose{
background-image:url(img/san_jose_back.png);
background-repeat: no-repeat;
background-size: contain;
width: 205px;
height: 205px;
display: flex;
justify-content: center;
align-items: center;
flex-direction:column;
}

.element{
padding: 10px;
color: white;
font-weight: bold;
font-family:Helvetica, monospace;
}

.day_elem{
padding: 3px;
}