-
Notifications
You must be signed in to change notification settings - Fork 12
html markup without styles #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kulikov98
wants to merge
10
commits into
epam-js-jun-2019:master
Choose a base branch
from
kulikov98:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
23f955f
html markup
kulikov98 6820336
add styles and fonts
kulikov98 d9840f2
add gulp, sass
kulikov98 8120056
reset commit
kulikov98 eb945a5
Merge branch 'master' of https://github.com/kulikov98/html-css-1
kulikov98 5277318
add BEM
kulikov98 81f56a6
code style improvements
kulikov98 55c5cbd
.gitignore fix
kulikov98 c5a5602
.gitignore update
kulikov98 ede6219
bug fix
kulikov98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| .DS_Store | ||
| Vladimir Kulikov/node_modules | ||
| Vladimir Kulikov/css | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| 'use strict'; | ||
|
|
||
| var gulp = require('gulp'); | ||
| var sass = require('gulp-sass'); | ||
| sass.compiler = require('node-sass'); | ||
| var sourcemaps = require('gulp-sourcemaps'); | ||
|
|
||
| gulp.task('sass', function () { | ||
| return gulp.src('./sass/**/*.scss') | ||
| .pipe(sourcemaps.init()) | ||
| .pipe(sass().on('error', sass.logError)) | ||
| .pipe(sourcemaps.write('./maps')) | ||
| .pipe(gulp.dest('./css')); | ||
| }); | ||
|
|
||
| gulp.task('sass:watch', function () { | ||
| gulp.watch('./sass/*.sass', gulp.parallel('sass')); | ||
| }); | ||
|
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
|
|
||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <meta http-equiv="X-UA-Compatible" content="ie=edge"> | ||
| <title>New Jersey</title> | ||
| <link rel="stylesheet" href="css/main.css"> | ||
| </head> | ||
|
|
||
| <body> | ||
| <div class="container"> | ||
| <article class="weather-widget"> | ||
| <section class="weather-widget__top"> | ||
| <div class="weather-widget__image"> | ||
| <img class="weather-widget__image-img" src="img/cloudy.png" alt="cloudy weather image"> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Class names for image and button are strange |
||
| <button class="weather-widget__image-btn" alt="update"></button> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, I misprinted. I meant |
||
| </div> | ||
| <div class="weather-widget__top-info"> | ||
| <div class="weather-widget__degrees">79 <sup class="weather-widget__degrees-symbol">o</sup></div> | ||
| <div class="weather-widget__text"> | ||
| <span class="weather-widget__sky">Cloudy Skies</span> | ||
| <span class="weather-widget__location">Sicklerville, New Jersey</span> | ||
| </div> | ||
| <div class="weather-widget__date">May<span class="weather-widget__date-day">21</span></div> | ||
| </div> | ||
| </section> | ||
| <section class="weather-widget__bottom"> | ||
| <div class="weather-widget__bottom-info"> | ||
| <span class="weather-widget__wind">2 MPH</span> | ||
| <span class="weather-widget__humidity">33%</span> | ||
| <span class="weather-widget__clear">83%</span> | ||
| </div> | ||
| <div class="weather-widget__pagination"> | ||
| <span class="weather-widget__dot weather-widget__dot_active"></span> | ||
| <span class="weather-widget__dot"></span> | ||
| <span class="weather-widget__dot"></span> | ||
| </div> | ||
| </section> | ||
| </article> | ||
| </div> | ||
| </body> | ||
|
|
||
| </html> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have script to create style.css file. That's why it also should be added in gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I just thought maybe you will not download this repo and compiled css files will be useful. Fixed)