Skip to content

feat: Add support onboarding git projects with access token #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MykolaMarusenko merged 1 commit into from
Oct 31, 2025
Merged

feat: Add support onboarding git projects with access token #232

MykolaMarusenko merged 1 commit into from
Oct 31, 2025

Conversation

@zmotso
Copy link
Member

@zmotso zmotso commented Oct 31, 2025

Pull Request Template

Description

Add support for onboarding git projects with an access token.

Fixes #231

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking change which improves an existing feature or documentation)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

How Has This Been Tested?

  • Unit tests
  • Manually

Checklist:

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contains one commit. I squash my commits.

@zmotso zmotso self-assigned this Oct 31, 2025
@zmotso zmotso requested a review from a team as a code owner October 31, 2025 08:29
@zmotso zmotso added the enhancement New feature or request label Oct 31, 2025
@zmotso zmotso marked this pull request as draft October 31, 2025 08:29
@zmotso zmotso marked this pull request as ready for review October 31, 2025 08:57
@zmotso
Copy link
Member Author

zmotso commented Oct 31, 2025

/recheck

@zmotso zmotso force-pushed the feat/231 branch 2 times, most recently from 7c598e7 to bee826b Compare October 31, 2025 09:33
@zmotso
feat: Add support onboarding git projects with access token (#231)
54d54d6 
With this change, the GitServer secret may not include the SSH key.
We can onboard a project only with a token.
If an SSH key and a token are provided,
the operator will use the SSH key by default.
@MykolaMarusenko MykolaMarusenko merged commit baa09f3 into master Oct 31, 2025
3 checks passed
@MykolaMarusenko MykolaMarusenko deleted the feat/231 branch October 31, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MykolaMarusenko MykolaMarusenko MykolaMarusenko approved these changes

Assignees

@zmotso zmotso

Labels

enhancement New feature or request

Projects

KubeRocketCI
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support onboarding git projects with Access Token in Codebase-Operator (equivalent to SSH key flow, without affecting SSH key usage)

3 participants

@zmotso @MykolaMarusenko