Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It should be impossible to add attachment point(s) to an atom with R-Group Label and vice versa #513

Closed
Svetlana-Asinovskaia opened this issue May 13, 2021 · 1 comment · Fixed by #983 or #1014
Closed

It should be impossible to add attachment point(s) to an atom with R-Group Label and vice versa #513

Svetlana-Asinovskaia opened this issue May 13, 2021 · 1 comment · Fixed by #983 or #1014
Assignees
@ElenaOdnoshivkina @AllaZhbanova
Labels
enhancement
Projects
Ketcher
Milestone
Release 2.4.0

Comments

@Svetlana-Asinovskaia
Copy link
Collaborator

Description: It's possible now to add attachment point(s) to an atom with R-Group Label and vice versa.

Steps to reproduce:

  1. Launch Ketcher.
  2. Create a structure (e.g. chain).
  3. With R-Group Label Tool add any R-Group label to any atom.
  4. With Attachment Point Tool add attachment points to the same atom.

Expected result: It's not possible to add attachment point(s) to an atom with R-Group Label.
Actual result: Attachment points are added.
image

The issue was discussed with @AlexanderSavelyev
@Svetlana-Asinovskaia Svetlana-Asinovskaia added this to the Backlog milestone May 13, 2021
@ElenaOdnoshivkina ElenaOdnoshivkina added this to In progress in Ketcher Nov 17, 2021
@ElenaOdnoshivkina ElenaOdnoshivkina linked a pull request Nov 18, 2021 that will close this issue
#513 It should be impossible to add attachment point(s) to an atom with R-Group Label and vice versa #983
Merged
@ElenaOdnoshivkina ElenaOdnoshivkina moved this from In progress to Code review in Ketcher Nov 18, 2021
AndreiMazol added a commit that referenced this issue Nov 22, 2021
@ElenaOdnoshivkina @AndreiMazol
#513 It should be impossible to add attachment point(s) to an atom wi…
224f23a 
…th R-Group Label and vice versa (#983)

* #940 Redesign the floating windows - Structure check (#971)

* redesign window

* redesign Structure check window

* fix styles

* adding monochrome style

* adding monochrome style

* forbid to add attachment point and rgroup label

* elements that are not available for tools are not highlighted

Co-authored-by: Andrei Mazol <Andrei_Mazol@epam.com>
@AndreiMazol AndreiMazol moved this from Code review to Ready for testing in Ketcher Nov 22, 2021
@AllaZhbanova AllaZhbanova moved this from Ready for testing to In testing in Ketcher Nov 22, 2021
@AllaZhbanova
Copy link

Fixed, tested v. 2.4

@AllaZhbanova AllaZhbanova moved this from In testing to Done in Ketcher Nov 22, 2021
AndreiMazol added a commit that referenced this issue Nov 24, 2021
@AndreiMazol
Revert "#513 It should be impossible to add attachment point(s) to an…
356dc74 
… atom with R-Group Label and vice versa (#983)"

This reverts commit 224f23a.
AndreiMazol added a commit that referenced this issue Nov 24, 2021
@AndreiMazol
Revert "#513 It should be impossible to add attachment point(s) to an…
05942b4 
… atom with R-Group Label and vice versa (#983)" (#1012)

This reverts commit 224f23a.
@AndreiMazol AndreiMazol moved this from Done to Ready for testing in Ketcher Nov 24, 2021
@AndreiMazol AndreiMazol linked a pull request Nov 24, 2021 that will close this issue
#513 It should be impossible to add attachment point(s) to an atom with R-Group Label and vice versa #1014
Merged
@AllaZhbanova AllaZhbanova moved this from Ready for testing to In testing in Ketcher Nov 25, 2021
@AllaZhbanova AllaZhbanova moved this from In testing to Done in Ketcher Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaOdnoshivkina ElenaOdnoshivkina

@AllaZhbanova AllaZhbanova

Labels
enhancement
Projects
Ketcher
  
Done
Milestone
Release 2.4.0
4 participants
@AndreiMazol @Svetlana-Asinovskaia @ElenaOdnoshivkina @AllaZhbanova