Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical/Horizontal flip hot keys don't work correctly #524

Closed
Svetlana-Asinovskaia opened this issue May 19, 2021 · 0 comments · Fixed by #605
Closed

Vertical/Horizontal flip hot keys don't work correctly #524

Svetlana-Asinovskaia opened this issue May 19, 2021 · 0 comments · Fixed by #605
Assignees
Projects
Milestone

Comments

@Svetlana-Asinovskaia
Copy link
Collaborator

Svetlana-Asinovskaia commented May 19, 2021

Tested on Ketcher v2.2.1-104-gc7896113

Steps to reproduce:

  1. Launch Ketcher.
  2. Open the structure from file
    struct.zip
  3. Click the 'Horizontal Flip' button.
  4. Click 'Alt+H' hot key.

Expected result: It's possible to make the horizontal flip using the 'Alt+H' hot key.

Actual result: The structure is not flipped with the 'Alt+H' hot key.
2021-05-19_18h32_05

The issue is reproduced with 'Vertical Flip' tool.

@Svetlana-Asinovskaia Svetlana-Asinovskaia added this to the Backlog milestone May 19, 2021
@AndreiMazol AndreiMazol added this to To do in Ketcher Jun 15, 2021
@AndreiMazol AndreiMazol modified the milestones: Backlog, Release 2.3.0 Jun 15, 2021
@AleksandrPokrovskii AleksandrPokrovskii moved this from To do to In progress in Ketcher Jun 21, 2021
@AleksandrPokrovskii AleksandrPokrovskii moved this from In progress to Code review in Ketcher Jun 28, 2021
@AleksandrPokrovskii AleksandrPokrovskii moved this from Code review to In progress in Ketcher Jun 30, 2021
@AleksandrPokrovskii AleksandrPokrovskii removed this from the Release 2.3.0 milestone Jul 5, 2021
@AleksandrPokrovskii AleksandrPokrovskii moved this from In progress to To do in Ketcher Jul 5, 2021
@AleksandrPokrovskii AleksandrPokrovskii added this to the Release 2.3.0 milestone Jul 5, 2021
@AleksandrPokrovskii AleksandrPokrovskii moved this from To do to In progress in Ketcher Jul 5, 2021
@AleksandrPokrovskii AleksandrPokrovskii moved this from In progress to Code review in Ketcher Jul 5, 2021
AndreiMazol pushed a commit that referenced this issue Jul 6, 2021
* hotkeys work after closing modal windows

* refactor working of hotkeys after closing modals

* hotkeys work after closing modal windows

* update classes naming for Editor

Co-authored-by: Aleksandr Pokrovskii <“Aleksandr_Pokrovskii1@epam.com“>
@AleksandrPokrovskii AleksandrPokrovskii moved this from Code review to Ready for testing in Ketcher Jul 6, 2021
@MagomedGasanov MagomedGasanov moved this from Ready for testing to In testing in Ketcher Jul 7, 2021
@MagomedGasanov MagomedGasanov self-assigned this Jul 7, 2021
@MagomedGasanov MagomedGasanov moved this from In testing to Done in Ketcher Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Ketcher
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants