Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Why does hbsfy need to be installed in the root node_modules? #14

Closed
Techwraith opened this Issue Feb 21, 2014 · 2 comments

Comments

Projects
None yet
3 participants
{
  [Error: module "hbsfy/runtime" not found from "/Users/techwraith/dev/test-atomify-bundle/test.html.hbs"]
  filename: 'hbsfy/runtime',
  parent: '/Users/techwraith/dev/test-atomify-bundle/test.html.hbs'
}

Here's a link to a repo with a test case. I was trying to figure out a double compilation bug when I came across this.

https://github.com/Techwraith/test-atomify-bundle

I assume this is due to the generated code containing require('hbsfy/runtime'). That seems problematic for hbsfy being used as a second level (or deeper) dependency, since there is no way to convey the requirement to the top level project.

Owner

epeli commented Jul 21, 2014

The peer dependency is now dropped in hbsfy 2.0. Users must now manually install Handlebars to the top level. Hope this clears this issue.

@epeli epeli closed this Jul 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment