New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`_.reverse` is buggy #220

Open
mathiasbynens opened this Issue Jul 10, 2013 · 2 comments

Comments

Projects
None yet
3 participants
@mathiasbynens

mathiasbynens commented Jul 10, 2013

For example:

// To see which symbols are being used here, check:
// http://mothereff.in/js-escapes#1ma%C3%B1ana%20man%CC%83ana
naiveReverse('mañana mañana');
// → 'anãnam anañam'
// Wait, so now the tilde is applied to the `a` instead of the `n`? WAT.

Another issue is explained here: http://stackoverflow.com/a/16776380/96656 (Posting a link because GitHub won’t let me use the symbols in a comment.)

You could use Esrever for this. Something like:

_.reverse = require('esrever').reverse;
@terinjokes

This comment has been minimized.

Show comment
Hide comment
@terinjokes

terinjokes Oct 21, 2013

I'm pulling in the, uhm, "Missy Elliot algorithm" replacing the current _str.reverse and also added the Pile of Poo test. Waiting for phantomjs to install to run the unit tests.

terinjokes commented Oct 21, 2013

I'm pulling in the, uhm, "Missy Elliot algorithm" replacing the current _str.reverse and also added the Pile of Poo test. Waiting for phantomjs to install to run the unit tests.

terinjokes added a commit to terinjokes/underscore.string that referenced this issue Oct 21, 2013

@mathiasbynens

This comment has been minimized.

Show comment
Hide comment
@mathiasbynens

mathiasbynens Oct 21, 2013

Awesome! Nice work, @terinjokes! 👍

mathiasbynens commented Oct 21, 2013

Awesome! Nice work, @terinjokes! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment