Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve a document of insert method #450

Merged
merged 1 commit into from Sep 30, 2015
Merged

Improve a document of insert method #450

merged 1 commit into from Sep 30, 2015

Conversation

kjirou
Copy link
Contributor

@kjirou kjirou commented Sep 30, 2015

Hello.

I felt wrongness to document of insert;

insert("Hello ", 6, "world");
// => "Hello world"

It looked inserting rather than appending.

Please apply it if you like!

@stoeffel
Copy link
Collaborator

LGTM. Thx.

stoeffel added a commit that referenced this pull request Sep 30, 2015
@stoeffel
Merge pull request #450 from kjirou/improve-document-of-insert
4a4c7d7 
Improve a document of insert method
@stoeffel stoeffel merged commit 4a4c7d7 into esamattis:master Sep 30, 2015
@kjirou
Copy link
Contributor Author

kjirou commented Sep 30, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kjirou @stoeffel