Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests should fail for good reasons only #92

Merged
merged 3 commits into from Dec 19, 2020

Conversation

mdeff
Copy link
Collaborator

@mdeff mdeff commented Dec 18, 2020

Fixes the following test error that happened far too often.

20201216_055940

@mdeff mdeff force-pushed the deterministic-reduction-docstring branch 3 times, most recently from 820caf9 to 4ea3f21 Compare December 18, 2020 22:00
@coveralls
Copy link

coveralls commented Dec 18, 2020

Coverage Status

Coverage increased (+0.002%) to 88.594% when pulling 43dc6d5 on deterministic-reduction-docstring into f6b5a1f on master.

@mdeff mdeff force-pushed the deterministic-reduction-docstring branch from c8b91cd to dd545d8 Compare December 18, 2020 22:35
@mdeff
Copy link
Collaborator Author

mdeff commented Dec 18, 2020

And that's the key retrieval issue that often pops up as well.

20201218_232005

@mdeff mdeff changed the title make sparsification docstring deterministic (tests were often failing) tests should fail for good reasons only Dec 18, 2020
@mdeff mdeff force-pushed the deterministic-reduction-docstring branch from dd545d8 to 927673c Compare December 18, 2020 22:53
@mdeff
Copy link
Collaborator Author

mdeff commented Dec 18, 2020

Another kind of false test failures is the verification of hyperlinks. But that's pretty useful as hyperlinks tend to break now and then. We could run it without enforcing it to succeed, but I'm not sure whether we'll pay attention to it if it never fails.

http://tulip.labri.fr fails especially often.

20201219_000108

@mdeff
Copy link
Collaborator Author

mdeff commented Dec 18, 2020

Newer sphinx will retry failed hyperlinks (to handle rate-limits) in linkcheck sphinx-doc/sphinx@6b90a63. That should also help.

@mdeff mdeff requested a review from nperraud December 18, 2020 23:27
Copy link
Collaborator

@nperraud nperraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is good.

Good improvement to the function graph_sparsify

Thanks

@nperraud nperraud merged commit 70f47ea into master Dec 19, 2020
@mdeff mdeff deleted the deterministic-reduction-docstring branch December 19, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants