Skip to content

Feat/dark themes#1865

Merged
m0ksem merged 53 commits into
epicmaxco:release/1.5.0from
m0ksem:feat/dark-themes
Sep 5, 2022
Merged

Feat/dark themes#1865
m0ksem merged 53 commits into
epicmaxco:release/1.5.0from
m0ksem:feat/dark-themes

Conversation

@m0ksem
Copy link
Copy Markdown
Member

@m0ksem m0ksem commented May 28, 2022 •
edited
Loading

firefox_a82WxMzvMX
Better themes support and dark themes as well.

Breaking changes.

  • Colors changed according to Create color themes as service #744 (comment) (removed white, dark, black and gray colors)
    Added new colors to color-config: textLight, textDark, background, backgroundSoft, backgroundMute, shadow, focus.
  • Added auto text color for VaTimePicker and VaDatePicker relative to their backgrounds. Here can be performance issues, but it is optimized by maximum.
  • Removed useless CSS variables
  • Some component colors maybe changed to fit new color pallet.

TODO

  • Better types for vuestic color config colors (we must require colors such as primary, background etc, but user must be able to add own.)
  • Check if all colors used correctly.

closes #744
closes #1590
closes #1255
closes #1385
closes #757
closes #1858
closes #1867

m0ksem added 24 commits May 5, 2022 21:23
@m0ksem
Made useElementBackground demo.
e8f6141
@m0ksem
Added colors with alpha support to useElementBackground.
f6c216e
@m0ksem
Added sidebar transparent its demo.
633effb
@m0ksem
Optimize useElementBackground. Added debounce and reduced recalculati…
60abf44 
…on calls.
@m0ksem
Merge branch 'develop' into feat/element-background-hook
36dadbd
@m0ksem
Fix VaSidebarItem text color.
b4a1f4e
@m0ksem
Added temp cache optimization.
9478ab1
@m0ksem
Now VaTimePicker can be seen on dark background,
b709330
@m0ksem
Init color service update.
25d1ddf
@m0ksem
Fix docs Navbar, Sidebar, Input, Card issues.
b46b196
@m0ksem
Raw. Fix alert styles.
24ea784
@m0ksem
Merge branch 'develop' into feat/dark-themes
6986fc4
@m0ksem
Merge branch 'feat/element-background-hook' into feat/dark-themes
7026b1d
@m0ksem
Removed useless css vars, fix alert, button, carousel, checkbox, date…
fb2e55d 
…-picker, modal
@m0ksem
Fix all component problems in dark theme.
860ecb7
@m0ksem
Fix useElement background. Fixed algolia search in docs.
a88f186
@m0ksem
Removed old colors.
ae9d2ff
@m0ksem
Fix some transitions.
ceefa5c
@m0ksem
Optimization. Sidebar color demo fixes.
b47cde0
@m0ksem
Raw. Added docs theme examples.
7343168
@m0ksem
Improve docs dark theme.
0c5a00e
@m0ksem
Fix landing text colors.
b5475ce
@m0ksem
Fix docs header.
14698d4
@m0ksem
Removed unused css variables.
8865325
@m0ksem
Copy link
Copy Markdown
Member Author

m0ksem commented May 30, 2022

Theme demk from docs for now.

image
image

@m0ksem m0ksem marked this pull request as ready for review May 31, 2022 10:47
@m0ksem m0ksem requested a review from xxsavitski May 31, 2022 10:47
@m0ksem
Copy link
Copy Markdown
Member Author

m0ksem commented Aug 11, 2022

image
image

@m0ksem
Copy link
Copy Markdown
Member Author

m0ksem commented Sep 5, 2022

Merging to prevent conflicts in feture PRs. Stuff to do:

  • Optimize useElementBackgorund (with caching)
  • Update colors demo.
  • Setup theme service config.
  • Maybe rename color names.

@m0ksem m0ksem marked this pull request as ready for review September 5, 2022 14:34
@m0ksem m0ksem merged commit 25dcfe4 into epicmaxco:release/1.5.0 Sep 5, 2022
This was referenced Sep 5, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RVitaly1978 RVitaly1978 RVitaly1978 left review comments

@xxsavitski xxsavitski Awaiting requested review from xxsavitski

Assignees

@xxsavitski xxsavitski

@m0ksem m0ksem

Labels

breaking change feature Something useful to end user

Projects

None yet

Milestone

1.5.0

3 participants

@m0ksem @xxsavitski @RVitaly1978