Skip to content

Feat/dark themes #1865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 53 commits into from
Sep 5, 2022
Merged

Feat/dark themes #1865

merged 53 commits into from
Sep 5, 2022

Conversation

m0ksem
Copy link
Collaborator

@m0ksem m0ksem commented May 28, 2022

firefox_a82WxMzvMX
Better themes support and dark themes as well.

Breaking changes.

  • Colors changed according to Create color themes as service #744 (comment) (removed white, dark, black and gray colors)
    Added new colors to color-config: textLight, textDark, background, backgroundSoft, backgroundMute, shadow, focus.
  • Added auto text color for VaTimePicker and VaDatePicker relative to their backgrounds. Here can be performance issues, but it is optimized by maximum.
  • Removed useless CSS variables
  • Some component colors maybe changed to fit new color pallet.

TODO

  • Better types for vuestic color config colors (we must require colors such as primary, background etc, but user must be able to add own.)
  • Check if all colors used correctly.

closes #744
closes #1590
closes #1255
closes #1385
closes #757
closes #1858
closes #1867

@m0ksem
Copy link
Collaborator Author

m0ksem commented May 30, 2022

Theme demk from docs for now.

image
image

@m0ksem m0ksem marked this pull request as ready for review May 31, 2022 10:47
@m0ksem m0ksem requested a review from xx13 May 31, 2022 10:47
@m0ksem
Copy link
Collaborator Author

m0ksem commented Aug 11, 2022

image
image

@m0ksem
Copy link
Collaborator Author

m0ksem commented Sep 5, 2022

Merging to prevent conflicts in feture PRs. Stuff to do:

  • Optimize useElementBackgorund (with caching)
  • Update colors demo.
  • Setup theme service config.
  • Maybe rename color names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change feature Something useful to end user
Projects
None yet
3 participants