Feat/css colors helpers #1890
Closed
Feat/css colors helpers #1890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add types feat: provide plugin through the vuestic configurations
rustem-nasyrov
requested review from
asvae,
Derranion,
m0ksem,
RVitaly1978 and
aluarius
aluarius
reviewed
Jun 1, 2022
| @@ -3346,7 +3353,8 @@ | |||
| "readMore": "Подробнее", | |||
| "icons": "Конфигурация иконок", | |||
| "components": "Конфигурация компонентов", | |||
| "colors": "Конфигурация цветов" | |||
| "colors": "Конфигурация цветов", | |||
| "colorsCustomClasses": "Custom classes for the colors" | |||
|
Thanks! Implementation wise looks good, but I hope to discuss what place would this solution take in context of vuestic-ui. |
aluarius
approved these changes
Jun 1, 2022
|
Let's discuss prerender and some caching here... It looks good, but something is missing here I believe... |
Yeah, sure. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #1222
closes #764 #2169
Description
Added customized classes for the given colors configuration.
colorsCustomClassesplugin for the Vuestic-UI.Types of changes