[#1725] VaSplit component implementation - #2068
Merged
Merged
Conversation
aluarius
requested review from
Derranion,
RVitaly1978,
asvae,
m0ksem and
rustem-nasyrov
July 10, 2022 08:56
m0ksem
approved these changes
Jul 10, 2022
m0ksem
left a comment
m0ksem
left a comment
Member
There was a problem hiding this comment.
Would be nice to have real-world example (like Sidebar and App content.)
Have you tested this on phone? You will need to listen for touchstart, touchend events.
rustem-nasyrov
suggested changes
Jul 11, 2022
rustem-nasyrov
left a comment
rustem-nasyrov
left a comment
Contributor
There was a problem hiding this comment.
Looks awesome! I have a little suggestion: if the cursor goes out of the splitter container we lose the 'draggable' state, would be better if the user can move the splitter out of the container.
rustem-nasyrov
approved these changes
Jul 11, 2022
fix:minor fix fix:redundant limits prop changed to number
fix:minor fix fix:redundant limits prop changed to number
m0ksem
reviewed
Jul 12, 2022
asvae
reviewed
Jul 14, 2022
feat:added resize observer to the container (to recalc limits) feat:docs updates
RVitaly1978
requested changes
Jul 18, 2022
RVitaly1978
reviewed
Jul 19, 2022
fix: review fixes
RVitaly1978
requested changes
Jul 19, 2022
RVitaly1978
approved these changes
Jul 27, 2022
# Conflicts: # packages/docs/src/locales/en/en.json # packages/docs/src/locales/ru/ru.json
Contributor
Author
|
From discussion with Vitaly:
|
m0ksem
approved these changes
Aug 3, 2022
| }) | ||
|
|
||
| switch (measureValue) { | ||
| case '%': |
Contributor
Author
There was a problem hiding this comment.
We have to parse value anyway. So, this suggestion isn't suitable in my opinion.
Comment on lines
+126
to
+130
| case '': | ||
| return 100 | ||
| default: | ||
| warn('Invalid limits measure!') | ||
| return 0 |
Member
There was a problem hiding this comment.
default:
if (v !== Number(v)) warn('puk')
Member
|
Can we also have some specs like this? We will put it later under documentation page. It takes too much time to understand how it works... |
fix: review suggestions refactor: minor docs refactor
fix: minor demo fix
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #1725
Description
New split component implementation.
Types of changes