-
Notifications
You must be signed in to change notification settings - Fork 357
docs: dropdown #2109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
docs: dropdown #2109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m0ksem
commented
Jul 17, 2022
packages/ui/src/components/va-input/components/VaInputWrapper/_variables.scss
Show resolved
Hide resolved
RVitaly1978
requested changes
Jul 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/ui/src/components/va-dropdown/hooks/useAnchorSelector.ts
Outdated
Show resolved
Hide resolved
packages/ui/src/components/va-dropdown/hooks/useAnchorSelector.ts
Outdated
Show resolved
Hide resolved
We need to make user able to remove "prevent-overflow" feature. Prevent overflow actually force us to use requestAnimationFrame which is not usually needed so we make up performance. |
Dropdown must react different on events if it touch events. For example:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was making docs found a lot of issues... Fixed them here.
closes #1494
closes #1969
closes #1154
closes #890
closes #849
closes #2125