Skip to content

docs: dropdown #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 22, 2022
Merged

docs: dropdown #2109

merged 15 commits into from
Jul 22, 2022

Conversation

m0ksem
Copy link
Collaborator

@m0ksem m0ksem commented Jul 16, 2022

While I was making docs found a lot of issues... Fixed them here.

closes #1494
closes #1969
closes #1154
closes #890
closes #849
closes #2125

image

@m0ksem m0ksem added BUG Something isn't working docs packages/docs labels Jul 16, 2022
@m0ksem m0ksem marked this pull request as ready for review July 16, 2022 23:22
Copy link
Member

@RVitaly1978 RVitaly1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • bug (or feature) on hover: content doesn't disappear after hover:

chrome-capture-2022-6-20

  • stickToEdges doesn't work for all components (select, time-input, date-input, popover):
Screen.Recording.2022-07-20.at.12.25.56.mov
  • example documentation Placement and Offset needs some updates:
    • show anchor border
    • move header

chrome-capture-2022-6-20 (1)

@m0ksem m0ksem marked this pull request as draft July 20, 2022 09:48
@m0ksem m0ksem mentioned this pull request Jul 21, 2022
@asvae asvae added the epic Feature that is too big to fit in one issue label Jul 21, 2022
@m0ksem
Copy link
Collaborator Author

m0ksem commented Jul 22, 2022

We need to make user able to remove "prevent-overflow" feature. Prevent overflow actually force us to use requestAnimationFrame which is not usually needed so we make up performance.

@m0ksem m0ksem marked this pull request as ready for review July 22, 2022 20:16
@m0ksem
Copy link
Collaborator Author

m0ksem commented Jul 22, 2022

Dropdown must react different on events if it touch events. For example:

  • trigger hover must open on touch click, since there is no hover.
  • trigger right-click must work if it is long press.

@m0ksem m0ksem merged commit e24f3c5 into epicmaxco:develop Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working docs packages/docs epic Feature that is too big to fit in one issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VaDropdown has a lot of divs contextual popover on right click Dropdown docs Close Dropdown on window blur Slot data bind for VaDropdown
4 participants