docs: dropdown - #2109
Merged
Merged
Conversation
m0ksem
marked this pull request as ready for review
July 16, 2022 23:22
m0ksem
commented
Jul 17, 2022
RVitaly1978
requested changes
Jul 20, 2022
Member
There was a problem hiding this comment.
- bug (or feature) on hover: content doesn't disappear after hover:
stickToEdgesdoesn't work for all components (select, time-input, date-input, popover):
Screen.Recording.2022-07-20.at.12.25.56.mov
- example documentation Placement and Offset needs some updates:
- show anchor border
- move header
Member
Author
|
We need to make user able to remove "prevent-overflow" feature. Prevent overflow actually force us to use requestAnimationFrame which is not usually needed so we make up performance. |
m0ksem
marked this pull request as ready for review
July 22, 2022 20:16
Member
Author
|
Dropdown must react different on events if it touch events. For example:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was making docs found a lot of issues... Fixed them here.
closes #1494
closes #1969
closes #1154
closes #890
closes #849
closes #2125