[#27] [#774] breakpoints service, wise gutters - #2189
Merged
aluarius merged 28 commits intoSep 15, 2022
Conversation
# Conflicts: # packages/ui/src/services/global-config/global-config.ts # packages/ui/src/services/global-config/types.ts
aluarius
requested review from
Derranion,
RVitaly1978,
asvae,
m0ksem and
rustem-nasyrov
August 1, 2022 13:19
Member
|
Can we have some type of gutters, while it adds space only between items, but not around them? In addition to current gutters. Quite useful feature, for me at least. |
Contributor
Author
Done.
Spacing between items also depends on current breakpoint. |
m0ksem
approved these changes
Aug 3, 2022
m0ksem
left a comment
m0ksem
left a comment
Member
There was a problem hiding this comment.
Looks good. Le't show some 😎 in plugin service folder and merge it.
Closed
RVitaly1978
requested changes
Aug 25, 2022
rustem-nasyrov
approved these changes
Aug 26, 2022
Contributor
|
Oh, I've missed in PR description, that we need to update the docs. |
Contributor
Author
it's ok, docs are already updated and mentioned problems will be moved to different issues because the are not linked to this one. |
m0ksem
requested changes
Aug 27, 2022
# Conflicts: # packages/ui/src/composables/index.ts
4 tasks
RVitaly1978
requested changes
Sep 14, 2022
# Conflicts: # packages/docs/src/layouts/default.vue # packages/docs/src/page-configs/styles/grid/examples/Gutters.vue # packages/ui/src/composables/index.ts # packages/ui/src/styles/grid/VaCssGridTest.demo.vue
feat: all demos included to demo route
RVitaly1978
approved these changes
Sep 14, 2022
asvae
reviewed
Sep 14, 2022
| @@ -0,0 +1,19 @@ | |||
| import { BreakpointsConfig, ThresholdsConfig } from './types' | |||
|
|
|||
| export const vaBreakpointsSymbol = Symbol('vaBreakpoints') | |||
Member
There was a problem hiding this comment.
I would suggest renaming breakpoints to breakpoint almost everywhere, similarly to how other services are implemented.
Logically, breakpoints would mean breakpoint list, which is not the case. Instead it's breakpoint service, which also contains other stuff.
asvae
reviewed
Sep 14, 2022
asvae
reviewed
Sep 14, 2022
feat: types update fix: template variable removed from examples and demos
This was referenced Sep 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #27
Close: #774
Close: #2216
Close: #2225
New breakpoints service with amount of features.
Description
This service allows us to:
lg (bool),lgUp (bool),lgDown (bool),width (number),height (number),current (string)etc.) inside of template or setup function;--va-media-ratiovariable for breakpoint-based calculations. For example, it's already done forguttersandspacings:Lg:
Sm:
Types of changes