[#27] [#774] breakpoints service, wise gutters #2189
Conversation
# Conflicts: # packages/ui/src/services/global-config/global-config.ts # packages/ui/src/services/global-config/types.ts
aluarius
requested review from
asvae,
Derranion,
m0ksem,
rustem-nasyrov and
RVitaly1978
|
Can we have some type of gutters, while it adds space only between items, but not around them? In addition to current gutters. Quite useful feature, for me at least. |
Done.
Spacing between items also depends on current breakpoint. |
packages/docs/src/page-configs/services/breakpoints/page-config.ts
Outdated
Show resolved
Hide resolved
packages/docs/src/page-configs/styles/smart-helpers/examples/Gutters.vue
Show resolved
Hide resolved
packages/docs/src/page-configs/services/breakpoints/code-examples/helpers.ts
Outdated
Show resolved
Hide resolved
|
Oh, I've missed in PR description, that we need to update the docs. |
it's ok, docs are already updated and mentioned problems will be moved to different issues because the are not linked to this one. |
# Conflicts: # packages/ui/src/composables/index.ts
# Conflicts: # packages/docs/src/layouts/default.vue # packages/docs/src/page-configs/styles/grid/examples/Gutters.vue # packages/ui/src/composables/index.ts # packages/ui/src/styles/grid/VaCssGridTest.demo.vue
feat: all demos included to demo route
| @@ -0,0 +1,19 @@ | |||
| import { BreakpointsConfig, ThresholdsConfig } from './types' | |||
|
|
|||
| export const vaBreakpointsSymbol = Symbol('vaBreakpoints') | |||
There was a problem hiding this comment.
I would suggest renaming breakpoints to breakpoint almost everywhere, similarly to how other services are implemented.
Logically, breakpoints would mean breakpoint list, which is not the case. Instead it's breakpoint service, which also contains other stuff.
feat: types update fix: template variable removed from examples and demos
Close: #27
Close: #774
Close: #2216
Close: #2225
New breakpoints service with amount of features.
Description
This service allows us to:
lg (bool),lgUp (bool),lgDown (bool),width (number),height (number),current (string)etc.) inside of template or setup function;--va-media-ratiovariable for breakpoint-based calculations. For example, it's already done forguttersandspacings:Lg:
Sm:
Types of changes