Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2190] Fix VaButtonDropdown dropdown appearance and alignment for split and left-icon #2201

Merged
merged 2 commits into from Aug 4, 2022

Conversation

RVitaly1978
Copy link
Contributor

Description

close #2190

changes:

  • set prevent-overflow to VaDropdown
  • set vertical-align: middle
  • update examples

chrome-capture-2022-7-3

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@RVitaly1978 RVitaly1978 added the BUG Something isn't working label Aug 3, 2022
@RVitaly1978 RVitaly1978 added this to the 04/08 (current) milestone Aug 3, 2022
@RVitaly1978 RVitaly1978 self-assigned this Aug 3, 2022
@m0ksem
Copy link
Contributor

m0ksem commented Aug 3, 2022

@RVitaly1978, why do we need setting prevent-overflow on dropdown? I think we must proxy dropdown props to components like VaButtonDropdown and VaSelect. By default, VaButtonDropdown shouldn't have prevent-overflow, but user must be able to set it.

If it doesn't work because of missing prevent-overflow, please, open another issue and merge this PR. Otherwise, proxy VaDropdown props like we do with VaInput in VaDateInput.

@m0ksem m0ksem merged commit 9aed667 into epicmaxco:develop Aug 4, 2022
@RVitaly1978 RVitaly1978 deleted the fix/button-dropdown branch August 22, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VaButtonDropdown: split doesn't work properly
4 participants