Skip to content

Tailwind CSS integration package #2745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Feb 13, 2023

Conversation

aluarius
Copy link
Contributor

@aluarius aluarius commented Dec 1, 2022

Related: #2184
Closes: #1287
Closes: #731

Description

  • New @vuestic/tailwind package for syncing Tailwind CSS -> Vuestic UI colors and breakpoint configs.
  • Deleted page about reset.css from docs.
  • grid docs page was totally rewritten .

While testing i've found out, that our color config does't understand colors with separators (red-500 is broken, but red500 is ok for example). Will investigate and fix it within another issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@asvae asvae mentioned this pull request Dec 11, 2022
@m0ksem m0ksem self-requested a review January 2, 2023 10:14
@asvae asvae force-pushed the feat/tailwind-integration branch from b5ea71c to 8d95a78 Compare January 24, 2023 02:00
Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're very close, but there are still some sharp edges.

I also updated docs a bit, hope you won't mind 😋.

I would suggest checking my comments, then asking @rustem-nasyrov or @LighthouseKeeperYN to try the flow on new project (one person tailwind -> vuestic, second - vuestic -> tailwind), then do final tweaks based on feedback.

@aluarius aluarius requested a review from asvae January 24, 2023 11:42
Copy link
Collaborator

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like bin commands name. sync-tailwind what does it mean? Let's imagine I'm new developer on project, how should I know what this command does? I would rename it to sync-tailwind-with-vuestic. or "vuestic sync-with-tailwind" "vuestic sync-to-tailwind". No winner yet. You can keep it as is. I hope there will be a plugin later.

@aluarius
Copy link
Contributor Author

Let's imagine I'm new developer on project, how should I know what this command does?

Open docs? :)

But i see your point, will rename them.

@aluarius aluarius merged commit bdd8731 into epicmaxco:develop Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange grid logic CSS helpers docs are not too nice
4 participants