Skip to content

feature: implement stepper component - #2906

Merged
m0ksem merged 13 commits into
epicmaxco:developfrom
LighthouseKeeperYN:feature/stepper-component
Feb 20, 2023
Merged

feature: implement stepper component#2906
m0ksem merged 13 commits into
epicmaxco:developfrom
LighthouseKeeperYN:feature/stepper-component

Conversation

@LighthouseKeeperYN

@LighthouseKeeperYN LighthouseKeeperYN commented Jan 31, 2023

Copy link
Copy Markdown
Contributor

close #2245

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Vuestic-UI-—-Vue-3-UI-framework

@m0ksem m0ksem added docs packages/docs feature Something useful to end user labels Jan 31, 2023

@rustem-nasyrov rustem-nasyrov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Have you used any references while you implemented this component?

I have a concerns about using templates instead of creating va-step-item component (or something similar).

  • We missing finish button on the last step.

image

  • Vertical example looks odd.

image

For example how it implemented in references image image
Details

Comment thread packages/docs/src/locales/en/en.json Outdated
@rustem-nasyrov

Copy link
Copy Markdown
Contributor

Also will be better to redo this demo. Imo it's also looks odd compared to the whole vuestic design.
image

Comment thread packages/ui/src/components/va-stepper/_variables.scss Outdated
Comment thread packages/ui/src/components/va-stepper/_variables.scss Outdated
Comment thread packages/ui/src/components/va-stepper/VaStepper.vue Outdated
Comment thread packages/ui/src/components/va-stepper/VaStepper.vue Outdated
Comment thread packages/ui/src/components/va-stepper/VaStepper.vue Outdated
Comment thread packages/ui/src/components/va-stepper/VaStepper.vue Outdated
Comment thread packages/ui/src/components/va-stepper/VaStepper.vue Outdated
Comment thread packages/ui/src/components/va-stepper/VaStepper.vue Outdated
Comment thread packages/ui/src/components/va-stepper/VaStepper.vue Outdated
Comment thread packages/ui/src/components/va-stepper/VaStepper.vue Outdated
Comment thread packages/ui/src/components/va-stepper/VaStepper.vue Outdated
Comment thread packages/docs/src/page-configs/ui-elements/stepper/examples/Default.vue Outdated
Comment thread packages/docs/src/page-configs/ui-elements/stepper/examples/Custom.vue Outdated
Comment thread packages/ui/src/components/va-stepper/VaStepper.vue
@m0ksem

m0ksem commented Feb 2, 2023

Copy link
Copy Markdown
Member

Two way:

<VaStepper>
   <MyStepOne #step-0 />
   <MyStepTwo #step-1 />
   <MyStepThree #step-2 />
</VaStepper>
<VaStepper>
  <VaStepItem>
    <MyStepOne />
  </VaStepItem>
  <VaStepItem>
    <MyStepTwo />
  </VaStepItem>
   <VaStepItem>
     <MyStepThree />
  </VaStepItem>
</VaStepper>

@LighthouseKeeperYN

Copy link
Copy Markdown
Contributor Author

Good job. Have you used any references while you implemented this component?

I have a concerns about using templates instead of creating va-step-item component (or something similar).

  • We missing finish button on the last step.
image
  • Vertical example looks odd.
image

For example how it implemented in references

Too difficult at this point.
#2971

Comment thread packages/ui/src/components/va-stepper/VaStepper.demo.vue
Comment thread packages/ui/src/components/va-stepper/VaStepperControls.vue
Comment thread packages/ui/src/components/va-stepper/VaStepperControls.vue
Comment thread packages/ui/src/components/va-stepper/VaStepper.vue Outdated
Comment thread packages/ui/src/components/va-stepper/VaStepperControls.vue
Comment thread packages/ui/src/components/va-stepper/VaStepperStepButton.vue Outdated
Comment thread packages/ui/src/components/va-stepper/VaStepperControls.vue Outdated
Comment thread packages/ui/src/components/va-stepper/VaStepperControls.vue Outdated
Comment thread packages/ui/src/components/va-stepper/VaStepper.vue Outdated

@rustem-nasyrov rustem-nasyrov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vue-book' demo doesn't work, but I suggest to move it to the new issue with known issues and suggestions for this component.
image

@aluarius aluarius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m0ksem
m0ksem merged commit 84a1ce2 into epicmaxco:develop Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs packages/docs feature Something useful to end user

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stepper component

4 participants