Skip to content

Feat/skeleton #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Feb 20, 2023
Merged

Feat/skeleton #2918

merged 16 commits into from
Feb 20, 2023

Conversation

m0ksem
Copy link
Collaborator

@m0ksem m0ksem commented Feb 3, 2023

image

Docs later in nuxt docs. Review component API (not sure how to make a good skeleton)

@m0ksem m0ksem added the component Is a new component or part of existing one label Feb 3, 2023
@m0ksem m0ksem self-assigned this Feb 3, 2023
@rustem-nasyrov
Copy link
Contributor

image

Missing translations or we planning to move at the next week to the nuxt docs?

rustem-nasyrov
rustem-nasyrov reviewed Feb 5, 2023
View reviewed changes
Copy link
Contributor

@rustem-nasyrov rustem-nasyrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

aluarius
aluarius reviewed Feb 6, 2023
View reviewed changes
rustem-nasyrov
rustem-nasyrov suggested changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@rustem-nasyrov rustem-nasyrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still don't have translations on the docs page.

asvae
asvae reviewed Feb 15, 2023
View reviewed changes
asvae
asvae reviewed Feb 15, 2023
View reviewed changes
@m0ksem m0ksem requested a review from asvae February 16, 2023 20:20
@m0ksem
Copy link
Collaborator Author

m0ksem commented Feb 16, 2023

Updated demos and docs.
image

@m0ksem
Copy link
Collaborator Author

m0ksem commented Feb 17, 2023

@aluarius, please check if accessibility is okay :)

rustem-nasyrov
rustem-nasyrov approved these changes Feb 18, 2023
View reviewed changes
Copy link
Contributor

@rustem-nasyrov rustem-nasyrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

aluarius
aluarius reviewed Feb 20, 2023
View reviewed changes
aluarius
aluarius reviewed Feb 20, 2023
View reviewed changes
Copy link
Contributor

@aluarius aluarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • No slot description in docs.
  • Will be fine to have real example of loading content using VaSkeleton (via setTimeout for example).

@m0ksem
Copy link
Collaborator Author

m0ksem commented Feb 20, 2023

Slots are not used here in VaSekeleton, so they're not in docs.

@m0ksem m0ksem merged commit 7ca7772 into epicmaxco:develop Feb 20, 2023
This was referenced Feb 22, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aluarius aluarius aluarius left review comments

@rustem-nasyrov rustem-nasyrov rustem-nasyrov approved these changes

@LighthouseKeeperYN LighthouseKeeperYN Awaiting requested review from LighthouseKeeperYN

@asvae asvae Awaiting requested review from asvae

Assignees

@m0ksem m0ksem

Labels
component Is a new component or part of existing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m0ksem @rustem-nasyrov @asvae @aluarius