Skip to content
Commits on Oct 25, 2010
  1. sort combo box by locale strcoll

    committed Oct 25, 2010
Commits on Oct 22, 2010
  1. @phuang

    Catch exceptions from os.kill.

    phuang committed Oct 22, 2010
    BUG=none
    TEST=manual
    
    Review URL: http://codereview.appspot.com/2659042
Commits on Oct 21, 2010
  1. @fujiwarat @phuang
  2. @fujiwarat @phuang
  3. @phuang

    Destroy existing connection before creating a new connection, and onl…

    phuang committed Oct 21, 2010
    …y create the fake context once.
    
    BUG=chromium-os:7998
    TEST=manual
    
    Review URL: http://codereview.appspot.com/2640041
  4. @yusukes
  5. @yusukes

    Remove compiler warnings.

    yusukes committed Oct 21, 2010
    BUG=none
    TEST=checked by ./autogen.sh && make
    
    Review URL: http://codereview.appspot.com/2632041
Commits on Oct 20, 2010
  1. @yusukes

    Enable key snooper by default again, except Chrome/Chromium browsers,…

    yusukes committed Oct 20, 2010
    … to fix application compatibility issues like 1068.
    
    This change is logically a revert of http://github.com/ibus/ibus/commit/7e715146794d5fa5324885f8d1dcebb8805bc31b
    
    The new behavior is:
    
    1) If IBUS_DISABLE_SNOOPER environment variable is set, and the value of the variable is "" (an empty string) or "0" or "false" or "False" or "FALSE", key snooper is enabled.
    2) If IBUS_DISABLE_SNOOPER environment variable is set, and the value of the variable is other than the 5 above, e.g. "1", "true", .., key snooper is disabled.
    3) If IBUS_DISABLE_SNOOPER environment variable is not set, and ibus-daemon is explicitly configured with --disable-key-snooper, key snooper is disabled.
    4) If IBUS_DISABLE_SNOOPER environment variable is not set, and ibus-daemon is not configured with --disable-key-snooper, the GTK_IM_MODULE, im-ibus.so, checks IBUS_NO_SNOOPER_APPS environment variable:
      4-a) if IBUS_NO_SNOOPER_APPS environment variable is not set, and the application name matches ".*chrome", key snooper is disabled.
      4-b) if IBUS_NO_SNOOPER_APPS environment variable, which should be comma-separated regexps, is set, and one of the regexps matches the application name, key snooper is disabled.
      4-c) otherwise, key snooper is enabled.
    
    Please note that when no configure options nor no environment variables are set, key snooper is enabled on all applications except Chrome/Chromium web browsers. For example, key snooper would be enabled on xchat and gedit by default. I believe the new default behavior would satisfy both Linux desktop and Chromium OS requirements.
    
    Test:
    
    - With ibus built without --disable-key-snooper:
    
    yusukes@harapeko:~$ gedit  # snoop
    yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER= gedit  # snoop
    yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER=0 gedit  # snoop
    yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER="0" gedit  # snoop
    yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER="false" gedit  # snoop
    yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER="False" gedit  # snoop
    yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER="FALSE" gedit  # snoop
    yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER="1" gedit  # no-snoop
    yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER="true" gedit  # no-snoop
    yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER="unknownstring" gedit  # no-snoop
    
    yusukes@harapeko:~$ IBUS_NO_SNOOPER_APPS=gedit gedit  # no-snoop
    yusukes@harapeko:~$ IBUS_NO_SNOOPER_APPS='g.*dit' gedit  # no-snoop
    yusukes@harapeko:~$ IBUS_NO_SNOOPER_APPS='foobar,g.*dit' gedit  # no-snoop
    yusukes@harapeko:~$ IBUS_NO_SNOOPER_APPS=foobar gedit  # snoop
    
    yusukes@harapeko:~$ google-chrome  # no-snoop
    yusukes@harapeko:~$ IBUS_NO_SNOOPER_APPS=foobar google-chrome  # snoop
    
    - With ibus built with --disable-key-snooper:
    
    yusukes@harapeko:~$ gedit  # no-snoop
    yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER="false" gedit  # snoop
    yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER="true" gedit  # no-snoop
    yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER="unknownstring" gedit  # no-snoop
    yusukes@harapeko:~$ IBUS_NO_SNOOPER_APPS=foobar gedit   # no-snoop, because IBUS_NO_SNOOPER_APPS is ignored when --disable-key-snooper is specified.
    
    BUG=http://code.google.com/p/ibus/issues/detail?id=1068
    TEST=manually done. see above.
    
    Review URL: http://codereview.appspot.com/2568043
  2. @phuang

    Always consume the hotkey, even if the hotkey associated engine alrea…

    phuang committed Oct 20, 2010
    …dy activated.
    
    BUG=6376
    TEST=manual
    
    Review URL: http://codereview.appspot.com/2596042
Commits on Oct 19, 2010
  1. @yusukes

    Fix race condition in bus_ibus_impl_create_engine()

    yusukes committed Oct 19, 2010
    If the bus_ibus_impl_create_engine() function is called right after an ibus_component_start() call, the function might fail getting a factory object.
    
    To avoid the problem, we should use the busy-wait logic even when ibus_component_is_running() returns true.
    
    BUG=http://crosbug.com/7244
    TEST=see the bug (comment #4,7,9)
    
    Review URL: http://codereview.appspot.com/2562041
Commits on Oct 13, 2010
  1. @fujiwarat @phuang
Commits on Oct 12, 2010
  1. @phuang

    Fix a typo.

    phuang committed Oct 13, 2010
Commits on Oct 8, 2010
  1. @phuang

    Remove unused dbus-1 package in gir includes

    phuang committed Oct 8, 2010
    BUG=none
    TEST=manual
    
    Review URL: http://codereview.appspot.com/2331041
Commits on Oct 1, 2010
  1. @yusukes

    Implement stress tool for ibus.

    Hirotake Kobayashi committed with yusukes Oct 2, 2010
    A test-stress.c sends key message each time by client.
    Client.h and client.c store modifier key and send key event.
    They check ibus-daemon and engine is alive.
    
    Review URL: http://codereview.appspot.com/2204051
    Patch from Hirotake Kobayashi <hkobayash@google.com>.
Commits on Sep 30, 2010
  1. @fujiwarat @phuang
Commits on Sep 20, 2010
  1. @phuang
  2. @yusukes

    Fix g_assertion failure in bus_ibus_impl_{load,save}_global_engine_na…

    yusukes committed Sep 17, 2010
    …me functions.
    
    Add NULL checks to the functions so they don't abort with assertion failure even if the functions are called before the ibus configuration daemon gets ready.
    See http://code.google.com/p/chromium-os/issues/detail?id=6689#c27 for details.
Commits on Sep 10, 2010
  1. @phuang

    Add some comments about registry

    phuang committed Sep 10, 2010
    BUG=none
    TEST=built fine
    
    Review URL: http://codereview.appspot.com/2159046
Commits on Sep 9, 2010
  1. Add Emacs modeline for .c and .h files.

    Satoru Takabayashi committed Sep 9, 2010
    /* -*- mode: C; c-basic-offset: 4; indent-tabs-mode: nil; -*- */
    
    TEST=confirmed that the modelines for vim and emacs both worked.
    BUG=none
    
    Review URL: http://codereview.appspot.com/2168042
  2. Move the log handler code from bus/main.cc to src/ibusshare.cc.

    Satoru Takabayashi committed Sep 9, 2010
    The log handler is useful for IBus client programs. For instance,
    the log handler was used inside the chromium browser for debugging
    IBus startup issue:
    
    http://code.google.com/p/chromium-os/issues/detail?id=6375#c29
    
    (chrome:11824): IBUS-DEBUG: 00:00:46.929430: The socket file is now created (monitoring done).
    
    BUG=none
    TEST=manually ran ibus-daemon with and without -v
    
    Review URL: http://codereview.appspot.com/2122047
Commits on Sep 8, 2010
  1. Add codereview.settings.

    Satoru Takabayashi committed Sep 8, 2010
    This is for us to use codereview.appspot.com for code reviews.
    
    Instructions to use codereview.appspot.com:
    
    1. Get depot_tools and add PATH to the directory
    http://dev.chromium.org/developers/how-tos/depottools
    
    2. In your local IBus git repository,
    
    % git checkout master
    % git checkout -b somefix
    make changes
    % git cl upload
    do code reviews at codereview.appspot.com
    once it's done, run "git cl push" if you can commit.
    otherwise, ask committers to commit on behalf.
    
    Review URL: http://codereview.appspot.com/2166043
Commits on Sep 7, 2010
  1. @phuang
Commits on Sep 6, 2010
  1. @phuang
  2. @fujiwarat @phuang
  3. @phuang
Commits on Aug 13, 2010
  1. @phuang

    Fix property issue.

    phuang committed Aug 12, 2010
Commits on Aug 6, 2010
  1. @phuang

    Update fr.po

    phuang committed Aug 6, 2010
Commits on Aug 5, 2010
  1. @phuang

    Fix a build warning

    phuang committed Aug 5, 2010
Commits on Aug 3, 2010
  1. @phuang

    Release 1.3.7

    phuang committed Aug 3, 2010
  2. @phuang

    Update ko.po

    phuang committed Aug 3, 2010
  3. @phuang

    Update po files.

    phuang committed Aug 3, 2010
Commits on Jul 31, 2010
  1. @phuang
  2. @phuang

    When the previous engine name is unknown, switch to the next engine i…

    satorux committed with phuang May 26, 2010
    …n menu.
    
    Before the change, hitting the "previous-engine" key does nothing if the
    previous engine name is unknown. The behavior is not good for users as
    they think the hot key is not working.
    
    TEST=manually on the netbook
    BUG=3579
    
    Review URL: http://codereview.chromium.org/2255002
  3. @suzhe @phuang

    Support engine specific hotkey.

    suzhe committed with phuang May 11, 2010
    BUG=http://crosbug.com/2543
    TEST=none
    
    With this CL, each engine can specify one or more special activation hotkeys. This CL doesn't support customizing global hotkeys per engine.
    I'd still prefer to customize the global hotkeys based on current locale rather than input method engine.
    
    Add hotkeys property to IBusEngineDesc, so that each engine can specify their own special hotkeys. This is useful for input methods that have dedicated hotkeys, such as Japanese input methods, which has a dedicated hotkey key: Kana.
    
    Review URL: http://codereview.chromium.org/1702015
Commits on Jul 30, 2010
  1. @phuang

    Update po files.

    phuang committed Jul 30, 2010
Something went wrong with that request. Please try again.