Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop: 0.66.0 → 0.67.2 (major) #34

Merged
merged 1 commit into from Apr 7, 2019

Conversation

Projects
None yet
1 participant
@depfu
Copy link
Contributor

commented Apr 6, 2019

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (0.66.0 → 0.67.2) · Repo · Changelog

Release Notes

0.67.2

Bug fixes

  • #6882: Fix an error for Rails/RedundantAllowNil when not using both allow_nil and allow_blank. (@koic)

0.67.1

Changes

  • #6881: Set default PreferredName to e for Naming/RescuedExceptionsVariableName. (@koic)

0.67.0

New features

  • #5184: Add new multiline element line break cops. (@maxh)
  • Add new cop Rails/ActiveRecordOverride that checks for overriding Active Record methods instead of using callbacks. (@elebow)
  • Add new cop Rails/RedundantAllowNil that checks for cases when allow_blank makes allow_nil unnecessary in model validations. (@elebow)
  • Add new Naming/RescuedExceptionsVariableName cop. (@AdrienSldy)

Bug fixes

  • #6761: Make Naming/UncommunicativeMethodParamName account for param names prefixed with underscores. (@thomthom)
  • #6855: Fix an exception in Rails/RedundantReceiverInWithOptions when the body is empty. (@ericsullivan)
  • #6856: Fix auto-correction for Style/BlockComments when the file is missing a trailing blank line. (@ericsullivan)
  • #6858: Fix an incorrect auto-correct for Lint/ToJSON when there are no to_json arguments. (@koic)
  • #6865: Fix deactivated StyleGuideBaseURL for Layout/ClassStructure. (@aeroastro)
  • #6868: Fix Rails/LinkToBlank auto-correct bug when using symbol for target. (@r7kamura)
  • #6869: Fix false positive for Rails/LinkToBlank when rel is a symbol value. (@r7kamura)
  • Add IncludedMacros param to default rubocop config for Style/MethodCallWithArgsParentheses. (@maxh)
  • #6785: Do not register an offense for Rails/Present or Rails/Blank in an unless else context when Style/UnlessElse is enabled. (@rrosenblum)

Changes

  • #6854: Mark Rails/LexicallyScopedActionFilter as unsafe and document risks. (@urbanautomaton)
  • #5977: Warn for Performance Cops. (@koic)
  • #6637: Move LstripRstrip from Performance to Style department and rename it to Strip. (@anuja-joshi)
  • #6875: Mention block form of Struct.new in Style/StructInheritance. (@XrXr)
  • #6871: Move Performance/RedundantSortBy, Performance/UnneededSort and Performance/Sample to the Style department. (@bbatsov)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 41 commits:

↗️ parallel (indirect, 1.14.0 → 1.17.0) · Repo

Commits

See the full diff on Github. The new version differs by 36 commits:

↗️ parser (indirect, 2.6.0.0 → 2.6.2.1) · Repo · Changelog

Release Notes

2.6.2.0 (from changelog)

API modifications:

  • Bump ruby versions to 2.5.5 and 2.6.2. (#563) (Ilya Bylich)
  • Bump Ruby version to 2.6.1. (#554) (Ilya Bylich)

Features implemented:

  • ruby27.y: dsym should be treated as string. (#560) (Ilya Bylich)
  • ruby27.y: Refactored symbol rules. (#557) (Ilya Bylich)
  • ruby27.y: Added method reference operator. (#556) (Ilya Bylich)
  • ruby27.y: branch parser. (#546) (Ilya Bylich)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 17 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the dependencies label Apr 6, 2019

@depfu depfu bot requested a review from epistrephein Apr 6, 2019

@epistrephein epistrephein merged commit 19c2f20 into master Apr 7, 2019

2 checks passed

Hound No violations found. Woof!
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@depfu depfu bot deleted the depfu/update/rubocop-0.67.2 branch Apr 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.