add param for oned log system #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xylakant
force-pushed
the
rebased/fasrc-add_oned_log_system_param
branch
from
c615996
to
c966cc2
Compare
|
@nmesstorff this one would be ready for review and merge |
this just asserts that the default still applies
* added specs that test that the param works * added parameter validation and specs for that * added the docstring for the new parameter
Xylakant
force-pushed
the
rebased/fasrc-add_oned_log_system_param
branch
from
c966cc2
to
c270348
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased version of #235