Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password checks are too aggressive for demo account #167

Closed
freggal opened this issue Aug 1, 2021 · 4 comments
Closed

Password checks are too aggressive for demo account #167

freggal opened this issue Aug 1, 2021 · 4 comments
Labels
Milestone

Comments

@freggal
Copy link

freggal commented Aug 1, 2021

Hi. I really like lms and use it daily.

One minor issue in the install instructions. The line
docroot = "/usr/share/lms/docroot/;/newroot/resources,/newroot/css,/newroot/images,/newroot/js,/newroot/favicon.ico";`
has an extraneous character right at the end, which fails the setup.

The query is how to access the player in Demo mode?
If I try to create a demo user, it tells me the password is too short.

Thanks

@epoupon
Copy link
Owner

epoupon commented Aug 1, 2021

Thanks for reporting this!
For the demo account, the only check should be that the password matches the user name.
Will check this!

@epoupon
Copy link
Owner

epoupon commented Aug 1, 2021

About the extra character, where is it?
I can't find it in

docroot = "/usr/share/lms/docroot/;/resources,/css,/images,/js,/favicon.ico";

How did you install lms?

Edit: ok just found it in the custom deploy path section!

@freggal
Copy link
Author

freggal commented Aug 1, 2021

I run the player inside an HA app (dashticz) iframe. I moved it to a "newroot" actually I call it "lmsplayer", and ngix is used to redirect it to Dashticz to avoid CORS issues.

@epoupon
Copy link
Owner

epoupon commented Aug 2, 2021

Indeed it looks like the password checker is way too aggressive now.
I guess it is a regression from cc28d89.

@epoupon epoupon added the bug label Aug 2, 2021
@epoupon epoupon added this to the v3.27.0 milestone Aug 2, 2021
@epoupon epoupon changed the title A small issue and a query about Demo mode Password checks are too aggressive Aug 2, 2021
@epoupon epoupon changed the title Password checks are too aggressive Password checks are too aggressive for demo account Aug 2, 2021
epoupon added a commit that referenced this issue Sep 2, 2021
@epoupon epoupon closed this as completed Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants