Error while compiling (<optional> header missing + hash<boost::asio::ip::address> redefinition)

[protozis]

OS: Archlinux

1. Missing header
   When compiling src/libs/utils/CMakeFiles/lmsutils.dir/impl/ChildProcess.cpp.o, it appears that the header file <optional> was missing. Adding the header to ChileProcess.hpp resolve the problem.

2. Object redefinition
   Following errors appeared while compiling:

Consolidate compiler generated dependencies of target lmsutils
[  0%] Building CXX object src/libs/utils/CMakeFiles/lmsutils.dir/impl/NetAddress.cpp.o
In file included from /home/jerry/public_html/lms/src/libs/utils/impl/NetAddress.cpp:20:
/home/jerry/public_html/lms/src/libs/utils/include/utils/NetAddress.hpp:26:27: error: redefinition of ‘struct std::hash<boost::asio::ip::address>’
   26 |         template<> struct hash<boost::asio::ip::address>
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/jerry/public_html/lms/src/libs/utils/include/utils/NetAddress.hpp:22,
                 from /home/jerry/public_html/lms/src/libs/utils/impl/NetAddress.cpp:20:
/usr/include/boost/asio/ip/address.hpp:271:8: note: previous definition of ‘struct std::hash<boost::asio::ip::address>’
  271 | struct hash<boost::asio::ip::address>
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/jerry/public_html/lms/src/libs/utils/impl/NetAddress.cpp:24:21: error: redefinition of ‘std::size_t std::hash<boost::asio::ip::address>::operator()(const boost::asio::ip::address&) const’
   24 |         std::size_t hash<boost::asio::ip::address>::operator()(const boost::asio::ip::address& ipAddr) const
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/jerry/public_html/lms/src/libs/utils/include/utils/NetAddress.hpp:22,
                 from /home/jerry/public_html/lms/src/libs/utils/impl/NetAddress.cpp:20:
/usr/include/boost/asio/ip/address.hpp:273:15: note: ‘std::size_t std::hash<boost::asio::ip::address>::operator()(const boost::asio::ip::address&) const’ previously defined here
  273 |   std::size_t operator()(const boost::asio::ip::address& addr)
      |               ^~~~~~~~
make[2]: *** [src/libs/utils/CMakeFiles/lmsutils.dir/build.make:160: src/libs/utils/CMakeFiles/lmsutils.dir/impl/NetAddress.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1515: src/libs/utils/CMakeFiles/lmsutils.dir/all] Error 2
make: *** [Makefile:146: all] Error 2

Maybe conflicting to the boost package?

[epoupon]

Hi !
Thanks for reporting this!

[epoupon]

Ok, got it:

Just remove/comment the whole NetAddress.hpp/cpp to move on, I will skip this for asio version < 1.76

[epoupon]

otherwise just cherry pick 7d0dae1

[protozis]

Nice! Thanks for the support.