Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phrase reloading in xpages only checks system.xml for changes #205

Open
jesusbagpuss opened this issue Feb 21, 2014 · 1 comment
Open

Phrase reloading in xpages only checks system.xml for changes #205

jesusbagpuss opened this issue Feb 21, 2014 · 1 comment

Comments

@jesusbagpuss
Copy link
Contributor

@jesusbagpuss jesusbagpuss commented Feb 21, 2014

For xpages in ~/archives/ARCHIVEID/cfg/lang/en/static/, only changes to phrases in system.xml are reflected real-time.
An edit to the xpage itself will reload all the phrase files next time the page is requested, but changing a phrase contained within e.g. ~/archives/ARCHIVEID/cfg/lang/en/phrases/test.xml that is referenced in ~/archives/ARCHIVEID/cfg/lang/en/static/test.xpage does not get reloaded.

@jesusbagpuss
Copy link
Contributor Author

@jesusbagpuss jesusbagpuss commented Apr 29, 2014

Notes:
~/perl_lib/EPrints/Update/Static.pm
sub update_static_file checks mod time of xpage file ($source_mtime) and resulting html ($target_mtime):
return if( defined $target_mtime && $target_mtime > $source_mtime );

It does not consider phrase files updates.

Notes2:
Major reworking in master branch using MapToStorage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants