Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views.pm : max_items bug #259

Closed
mpbraendle opened this issue Aug 6, 2014 · 1 comment
Closed

Views.pm : max_items bug #259

mpbraendle opened this issue Aug 6, 2014 · 1 comment

Comments

@mpbraendle
Copy link
Contributor

@mpbraendle mpbraendle commented Aug 6, 2014

perl_lib/EPrints/Update/Views.pm , around line 536:

# hit the limit
if ($count == $max_items+1)

results in a warning message if max_items is 0 (which means disabled max items limitation) and there is exactly 1 item in the view. Hence, the user cannot have a look at the item. In addition, comparing on equality is wrong here.

A possible bug fix is as follows:

+ # UZH CHANGE fixed bug, 2014/08/06/mb
+ # if ($count == $max_items+1)
+ if ($count > $max_items && $max_items != 0)
{
my $PAGE = $xml->create_element( "div",
class => "ep_view_page ep_view_page_view_$view->{id}"

phluid61 added a commit that referenced this issue Dec 5, 2014
@patrickmcsweeney
Copy link
Contributor

@patrickmcsweeney patrickmcsweeney commented Nov 18, 2015

fixed by 9392188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants