Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min_resolution doesn't actually do anything... #342

Open
jesusbagpuss opened this issue Sep 7, 2015 · 0 comments
Open

min_resolution doesn't actually do anything... #342

jesusbagpuss opened this issue Sep 7, 2015 · 0 comments

Comments

@jesusbagpuss
Copy link
Contributor

@jesusbagpuss jesusbagpuss commented Sep 7, 2015

...other than display a different help message.

https://github.com/eprints/eprints/search?utf8=%E2%9C%93&q=min_resolution

When rendering a field with a min_resolution of day/month, the '0' value should be removed from that select.
https://github.com/eprints/eprints/blob/3.3/perl_lib/EPrints/MetaField/Date.pm#L128-L130
https://github.com/eprints/eprints/blob/3.3/perl_lib/EPrints/MetaField/Date.pm#L211-L216

If a date is already set, and falls below the min_resolution required, it should be allowed to stand - the software shouldn't impose things - but a human should be presented with only the options to allow them to select a valid value!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants