Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in BibTeX import plugin #355

Closed
mamalos opened this issue Oct 29, 2015 · 0 comments
Closed

Bug in BibTeX import plugin #355

mamalos opened this issue Oct 29, 2015 · 0 comments

Comments

@mamalos
Copy link

@mamalos mamalos commented Oct 29, 2015

When importing an eprint (of type @TechReport) using the BibTeX plugin, monograph_type takes the value "technicalreport" instead of "technical_report" (the underscore is somehow omitted).

The following patch (by John Salter) makes it work again:

diff -r 9bdc1512e990 perl_lib/EPrints/Plugin/Import/BibTeX.pm
--- a/perl_lib/EPrints/Plugin/Import/BibTeX.pm  Thu Oct 29 12:57:25 2015 +0200
+++ b/perl_lib/EPrints/Plugin/Import/BibTeX.pm  Thu Oct 29 19:04:33 2015 +0200
@@ -340,7 +340,7 @@
        if( $type eq "TECHREPORT" )
        {
                $epdata->{type} = "monograph";
-               $epdata->{monograph_type} = "technical_report";
+               $epdata->{monograph_type} = "technical\\_report";
        }
        if( $type eq "MASTERSTHESIS" )
        {

but the problem is that "technical_report" was changed into "technical_report" in a previous commit specifically: cf70ab4 (as John Salter mentioned in the tech-list: http://www.eprints.org/tech.php/21001.html). In this patch, a few other escaped underscores were changed to simple underscores as well, which might have caused analogous issues in other places too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant