Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on_behalf_of and sword_error functions not being used consistently. #360

Closed
gobfrey opened this issue Nov 13, 2015 · 0 comments
Closed

on_behalf_of and sword_error functions not being used consistently. #360

gobfrey opened this issue Nov 13, 2015 · 0 comments

Comments

@gobfrey
Copy link
Contributor

@gobfrey gobfrey commented Nov 13, 2015

https://github.com/eprints/eprints/blob/3.3/perl_lib/EPrints/Apache/CRUD.pm#L1004
my( $rc, $owner ) = on_behalf_of( $repo, $r, $user );
return $rc if $rc != OK;

https://github.com/eprints/eprints/blob/3.3/perl_lib/EPrints/Apache/CRUD.pm#L1732
my $on_behalf_of = on_behalf_of( $repo, $r, $user );
if( $on_behalf_of->{status} != OK )
{
return sword_error( $repo, $r, %$on_behalf_of );
}
$on_behalf_of = $on_behalf_of->{on_behalf_of};

https://github.com/eprints/eprints/blob/3.3/perl_lib/EPrints/Apache/CRUD.pm#L1972
sub sword_error
{
my( $self, %opts ) = @_;

...note self is not passed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants