log interrupted downloads as 499 #253

Merged
merged 1 commit into from Sep 10, 2015

Conversation

Projects
None yet
3 participants
@phluid61
Contributor

phluid61 commented Jul 28, 2014

Changes the error regexp, per discussion in #119

@MrkGrgsn

This comment has been minimized.

Show comment
Hide comment
@MrkGrgsn

MrkGrgsn Jul 28, 2014

Contributor

Regarding the use of HTTP 499: in 3.2 we found that handling this error properly resulted in an HTTP 200 and EPrints then logged a successful full-text access. Given this was changing the measuring of access usage (suddenly a whole of 500 responses became 200s and were logged) and in a circumstance where the full-text was clearly not actually delivered to the user, we thought the 499 was the best option.

Contributor

MrkGrgsn commented Jul 28, 2014

Regarding the use of HTTP 499: in 3.2 we found that handling this error properly resulted in an HTTP 200 and EPrints then logged a successful full-text access. Given this was changing the measuring of access usage (suddenly a whole of 500 responses became 200s and were logged) and in a circumstance where the full-text was clearly not actually delivered to the user, we thought the 499 was the best option.

jiadiyao added a commit that referenced this pull request Sep 10, 2015

Merge pull request #253 from QUTlib/201407128-connection-abort
log interrupted downloads as 499
will port this over to 3.3

@jiadiyao jiadiyao merged commit ccbbed4 into eprints:master Sep 10, 2015

jiadiyao added a commit that referenced this pull request Sep 10, 2015

@phluid61 phluid61 deleted the QUTlib:201407128-connection-abort branch Apr 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment