Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix for #505 #506

Merged
merged 1 commit into from Apr 18, 2019
Merged

Possible fix for #505 #506

merged 1 commit into from Apr 18, 2019

Conversation

@jesusbagpuss
Copy link
Contributor

@jesusbagpuss jesusbagpuss commented Apr 17, 2019

This was the approximate solution I was thinking of - but it mat not be perfect - and would need validation under Apache 2.2 and Apache2.4, for code that does, and does not use the connection->remote_ip method.

The deparsed code block doesn't not contain comments (so wouldn't flag commented-out code - which I think is correct).
It may be that a link to a wiki page relating to the issue would be helpful to output - or alink to #214?

This was the approximate solution I was thinking of - but it mat not be perfect - and would need validation under Apache 2.2 and Apache2.4, for code that does, and does not use the `connection->remote_ip`  method.

The deparsed code block doesn't not contain comments (so wouldn't flag commented-out code - which I think is correct).
It may be that a link to a wiki page relating to the issue would be helpful to output - or alink to #214?
@drn05r
Copy link
Contributor

@drn05r drn05r commented Apr 18, 2019

This looks OK to merge in. I will test it myself to check it has the intended behaviour.

@drn05r drn05r added this to the 3.3.17 milestone Apr 18, 2019
@drn05r drn05r merged commit ba46271 into 3.3 Apr 18, 2019
@drn05r
Copy link
Contributor

@drn05r drn05r commented Apr 18, 2019

@jesusbagpuss I see what you mean by not being perfect. Unless you were really closely checking the Apache log file you would not spot this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants