Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eprints_lang cookie causes console warning about samesite attribute being inappropriately set #118

Closed
drn05r opened this issue Jan 21, 2021 · 0 comments
Assignees
Labels
Milestone

Comments

@drn05r
Copy link
Collaborator

@drn05r drn05r commented Jan 21, 2021

FireFox console shows the following warning message:

Cookie “eprints_lang” will be soon rejected because it has the “SameSite” attribute set to “None” or an invalid value, without the “secure” attribute. To know more about the “SameSite“ attribute

Need to fix perl_lib/EPrints/Plugin/Screen/SetLang.pm to set SameSite, Secure and HttpOnly attributes appropriately depending if site is being served on HTTP or HTTPS.

@drn05r drn05r added the bug label Jan 21, 2021
@drn05r drn05r added this to the 3.4.3 milestone Jan 21, 2021
@drn05r drn05r self-assigned this Jan 21, 2021
@drn05r drn05r closed this in 707b70b Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant