Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent undepositable subjects beting unset when eprint is edited #144

Closed
drn05r opened this issue Apr 14, 2021 · 2 comments
Closed

Prevent undepositable subjects beting unset when eprint is edited #144

drn05r opened this issue Apr 14, 2021 · 2 comments
Assignees
Milestone

Comments

@drn05r
Copy link
Collaborator

@drn05r drn05r commented Apr 14, 2021

When a subjects type field is being displayed as a Field::Subject component then subjects that have been made undepositable still show as being set but if a standard component type is used then undepositable subjects are not display and if the user clicks through to the next stage these subjects will be unset without the user realising, which is undesirable.

Behaviour should be changed so the standard component type behaves the same as the Field::Subject component type and still displays undepositable subjects (at the top of the field) if they are currently selected for that item.

@drn05r drn05r added this to the 3.4.3 milestone Apr 14, 2021
@drn05r drn05r self-assigned this Apr 14, 2021
@drn05r drn05r closed this in dfd501f Apr 14, 2021
@drn05r
Copy link
Collaborator Author

@drn05r drn05r commented Sep 10, 2021

This has a number of issues:

  1. It does not handle subject fields that are not multiple.
  2. It does not check whether the values already selected are depositable or not so select values will be displayed twice.

@drn05r drn05r reopened this Sep 10, 2021
drn05r added a commit that referenced this issue Sep 10, 2021
@drn05r
Copy link
Collaborator Author

@drn05r drn05r commented Sep 10, 2021

Latest commit should fix the two bugs described.

@drn05r drn05r closed this Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant