Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp parameter to auto CSS and JS files #220

Closed
drn05r opened this issue Apr 28, 2022 · 0 comments
Closed

Add timestamp parameter to auto CSS and JS files #220

drn05r opened this issue Apr 28, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@drn05r
Copy link
Collaborator

@drn05r drn05r commented Apr 28, 2022

CSS caching is a perennial problem. This should be easy enough to fix with a ?TIMESTAMP, where timestamp is a number of seconds since start of last epoch when the last CSS or JS file used to generate auto-VERSION.css or auto-VERSION.js was modified. Code to generate this timestamp should be fairly easy. A couple of functions in Repository.pm for returning these timestamps and a Utils.pm function that returns the timestamp for the last modified file in a particular directory.

There is not real need to check if files are overrided in a subsequent directory or if the file modified is not CSS or JS, we just want a timestamp that does not change too often, that is removes the benefit of generally caching auto CSS and JS.

@drn05r drn05r added the enhancement New feature or request label Apr 28, 2022
@drn05r drn05r added this to the 3.4.4 milestone Apr 28, 2022
@drn05r drn05r self-assigned this Apr 28, 2022
@drn05r drn05r closed this as completed in d940ee2 Apr 29, 2022
drn05r added a commit that referenced this issue May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant