Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazaar inaccessible behind HTTP proxy #7

Closed
alex-ball opened this issue May 9, 2019 · 3 comments
Closed

Bazaar inaccessible behind HTTP proxy #7

alex-ball opened this issue May 9, 2019 · 3 comments
Assignees
Milestone

Comments

@alex-ball
Copy link
Contributor

@alex-ball alex-ball commented May 9, 2019

Running EPrints 3.4 with Perl 5.22 behind a HTTP proxy (and using HTTPS), I find that on the Admin::EPM screen, the list of available packages fails to load.

Adding the following lines to ingredients/bazaar/plugins/EPrints/EPM/Source.pm solves that problem:

use strict;
use LWP::Protocol::https; # <-- Add this line.
#...
sub accolades
{
        my( $_ua, $_base_url ) = @_;
 
        my $ua = ( $_ua ) ? $_ua : LWP::UserAgent->new;
        $ua->env_proxy;  # <-- Add this line.

I have not put this as a pull request as the actual code will need to be more carefully changed (e.g. dependent on Perl version) and I can't guarantee this is a complete fix as there may be related problems I haven't hit yet.

@drn05r
Copy link
Collaborator

@drn05r drn05r commented May 9, 2019

I also suspect that LWP::Protocol::https will not always be installed on a repository's server, so will cause dependency issue on future upgrades for a problem that only presents itself if you are using an HTTP proxy.

I can see there is the DEB liblwp-protocol-https-perl and the RPM perl-LWP-Protocol-https, so it should be fairly easy to install.

@drn05r
Copy link
Collaborator

@drn05r drn05r commented Nov 15, 2019

I will make sure 3.4.2 packages include the package dependencies and otherwise update install instructions.

@drn05r drn05r added this to the 3.4.2 milestone Nov 15, 2019
@drn05r drn05r self-assigned this Nov 15, 2019
@drn05r drn05r closed this as completed in 023d396 Apr 13, 2020
@drn05r
Copy link
Collaborator

@drn05r drn05r commented Apr 13, 2020

LWP::Protocol::https is already used by EPrints and you will get a warning message on the Bazaar page if it is not installed telling you to install it. use_proxy is already used when loading the the Bazaar page itself, so adding it for loading accolades should not make any difference and make this consistent.

Installing the DEB/RPM needed for LWP::Protocol::https have been added to the dependencies on the appropriate EPrints wiki pages. They will also be added to any future eprints DEB or RPMs produced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants