Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in OrcidSync.pm #5

Closed
GFournie opened this issue Jun 13, 2018 · 1 comment
Closed

Error in OrcidSync.pm #5

GFournie opened this issue Jun 13, 2018 · 1 comment

Comments

@GFournie
Copy link

@GFournie GFournie commented Jun 13, 2018

Hi,

It seems that the $employment et $institution members in OrcidSync.pm are not defined properly...

We had to change from :

foreach my $employment ( @{$json_text->{"$affiliation-summary"}} )
{
        if( $employment->{'organization'}->{'disambiguation-organization-identifier'} eq $institution->{'organization'}->{'disambiguation-organization-identifier'} )
        {
                $add_institution = 0;
        }
}

to :

foreach my $employment ( @{$json_text->{"$affiliation-summary"}} )
{
        my $orgid1 = $institution->{'organization'}->{'disambiguated-organization'}->{'disambiguated-organization-identifier'};
        my $orgid2 = $employment->{'organization'}->{'disambiguated-organization'}->{'disambiguated-organization-identifier'};
        if( $orgid1 eq $orgid2 )
        {
                $add_institution = 0;
        }
}
wfyson added a commit that referenced this issue Jul 31, 2018
…he user's orcid.org profile were not being checked correctly.
@wfyson
Copy link
Collaborator

@wfyson wfyson commented Jul 31, 2018

Thanks for alerting us to this! Fixed with commit 376c7bb

@wfyson wfyson closed this Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants