Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

var readers = [ 'mendeley', 'connotea', 'citeulike' ]; #1

Closed
photomedia opened this issue Aug 31, 2016 · 5 comments
Closed

var readers = [ 'mendeley', 'connotea', 'citeulike' ]; #1

photomedia opened this issue Aug 31, 2016 · 5 comments

Comments

@photomedia
Copy link

@photomedia photomedia commented Aug 31, 2016

Connotea discontinued service on March 12, 2013.

in 99_altmetric.js we have:
var readers = [ 'mendeley', 'connotea', 'citeulike' ];

Should remove Connotea from the list, because it will be 0.

@photomedia
Copy link
Author

@photomedia photomedia commented Aug 31, 2016

About this, it may be better to modify this line so that none of the 0 result readers show up:

in 99_altmetrics.js we have:
line 73 if (value != null)

Change to the following to remove "0" results in the readers:
line 73 if(( value != null ) && (value != 0))

jesusbagpuss referenced this issue Sep 1, 2016
* Don't display 0 counts for readers (Connotea will always be 0 now)
* Include reference to list of citation types (default values have not been changed).
@jesusbagpuss
Copy link
Contributor

@jesusbagpuss jesusbagpuss commented Sep 12, 2016

@photomedia - do you want to try installing the latest package on a dev repo - in case I've made any mistakes (seems to work OK on 3.3.10)?
It will now use DOIs or ISBNs to display data. An example ISBN that actually has some data attached is: 978-3-319-25557-6 - in case you need it to test properly.

@photomedia
Copy link
Author

@photomedia photomedia commented Sep 14, 2016

Thank you for the updates! Sorry for the delay, it's a very busy time of year. The changes look OK to me, but I'm unsure why you added an extra screen and what permissions are required for accessing the screen? I didn't try this update yet on a repository, but when I do, I will report how it goes.

@jesusbagpuss
Copy link
Contributor

@jesusbagpuss jesusbagpuss commented Sep 15, 2016

Hi Tomsaz,
The Altmetric API can handle DOIs, ISBNs, PMIDs, and other identifiers.
This package will allow any of these to be used - but as they may exist in other fields, I added a config function to allow someone to alter this at the repo level.
The screen I added is for repo admins - and makes changing this function easier (and also adding the API key if you have one).

I've tested this in 3.3.10, and made it live in production. I didn't want to push it to the Bazaar until I've got more evidence that it's good!

@jesusbagpuss
Copy link
Contributor

@jesusbagpuss jesusbagpuss commented Feb 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants