Skip to content
Browse files

Fix get_type/2 by accepting list as type

when executable command takes arguments, type is list and it causes following error:

localhost [/home/hirotnk/repo/github/grapherl%] ./grapherl -m -t png "/usr/lib64/erlang/lib/thrift-0.8.0/ebin" thrift.png                                                                                                                          [1:39 13-04-06]
escript: exception error: bad argument
  in function  atom_to_list/1
     called as atom_to_list("png")
  in call from grapherl:get_type/2 (src/grapherl.erl, line 199)
  in call from grapherl:create/3 (src/grapherl.erl, line 216)
  in call from grapherl:modules/3 (src/grapherl.erl, line 160)
  in call from grapherl:run/2 (src/grapherl.erl, line 88)
  in call from escript:run/2 (escript.erl, line 741)
  in call from escript:start/1 (escript.erl, line 277)
  in call from init:start_it/1
  • Loading branch information...
1 parent 835ba82 commit 538b78057a1e91865db948b5f21da5dd2a1f81fe Yoshihiro Tanaka committed Apr 6, 2013
Showing with 2 additions and 1 deletion.
  1. +2 −1 src/grapherl.erl
3 src/grapherl.erl
@@ -196,7 +196,8 @@ stop_xref(Ref) ->
get_type(Options, Target) ->
case proplists:get_value(type, Options) of
undefined -> type_from_filename(Target);
- Type -> atom_to_list(Type)
+ Type when is_atom(Type) -> atom_to_list(Type);
+ Type -> Type
type_from_filename(Filename) ->

0 comments on commit 538b780

Please sign in to comment.
Something went wrong with that request. Please try again.