Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Run action on Node 16 #90

Merged
merged 2 commits into from Oct 29, 2022
Merged

test: Run action on Node 16 #90

merged 2 commits into from Oct 29, 2022

Conversation

NotMyFault
Copy link
Contributor

The change proposed executes the action with Node 16, rather than 12.

This proposal aligns with GitHub's policy of moving workflows: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Actions still running on Node 12 are labeled as deprecated on every workflow run:
Screenshot 2022-10-12 at 09 13 26

@eps1lon eps1lon self-requested a review Oct 12, 2022
@NotMyFault
Copy link
Contributor Author

Hey @eps1lon,

is there anything left, that keeps a review on hold?

Thanks!

@carlbuchmann
Copy link

+1 for this PR to be merged!

Copy link
Owner

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Not sure why GH actions didn't run on this one without me committing

@eps1lon eps1lon changed the title Run action on Node 16 test: Run action on Node 16 Oct 29, 2022
@eps1lon eps1lon merged commit 4d757c0 into eps1lon:main Oct 29, 2022
2 checks passed
@NotMyFault NotMyFault deleted the node-16 branch Oct 29, 2022
@NotMyFault
Copy link
Contributor Author

Thanks. Not sure why GH actions didn't run on this one without me committing

Likely needed a first time approval for me, but worked all right in #92 🤷🏻

@eps1lon
Copy link
Owner

eps1lon commented Oct 29, 2022

Likely needed a first time approval for me, but worked all right in #92 🤷🏻

But then it should've displayed that button. Also, I specifically set the repo up to only require approval from new GH users which you certainly aren't.

Maybe I changed the setting while the PR was open so the UI thought "this person doesn't require approval" while the GH action didn't check all PRs when I changed the setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants