From ca8b36759d38e84574897839d239ddd791851b15 Mon Sep 17 00:00:00 2001 From: Wenche Tollevsen Date: Tue, 25 Aug 2020 11:45:39 +0200 Subject: [PATCH] Types for tokens library (#507) * Install typescript and types for react and react-dom * Add support for typescript by using .ts extensions for js files * Change file extensions to .ts in figma-broker --- apps/figma-broker/actions/createTokens.js | 4 ++-- libraries/tokens/base/{clickbounds.js => clickbounds.ts} | 0 libraries/tokens/base/{colors.js => colors.ts} | 0 libraries/tokens/base/{elevation.js => elevation.ts} | 0 libraries/tokens/base/{index.js => index.ts} | 0 libraries/tokens/base/{shape.js => shape.ts} | 0 libraries/tokens/base/{spacings.js => spacings.ts} | 0 libraries/tokens/base/{typography.js => typography.ts} | 0 libraries/tokens/{index.js => index.ts} | 0 libraries/tokens/package.json | 3 ++- libraries/tokens/pnpm-lock.yaml | 9 +++++++++ 11 files changed, 13 insertions(+), 3 deletions(-) rename libraries/tokens/base/{clickbounds.js => clickbounds.ts} (100%) rename libraries/tokens/base/{colors.js => colors.ts} (100%) rename libraries/tokens/base/{elevation.js => elevation.ts} (100%) rename libraries/tokens/base/{index.js => index.ts} (100%) rename libraries/tokens/base/{shape.js => shape.ts} (100%) rename libraries/tokens/base/{spacings.js => spacings.ts} (100%) rename libraries/tokens/base/{typography.js => typography.ts} (100%) rename libraries/tokens/{index.js => index.ts} (100%) diff --git a/apps/figma-broker/actions/createTokens.js b/apps/figma-broker/actions/createTokens.js index 9586d752e2..c9c45770e2 100644 --- a/apps/figma-broker/actions/createTokens.js +++ b/apps/figma-broker/actions/createTokens.js @@ -21,7 +21,7 @@ const PATHS_ = { } const writeJSTokens = (tokens) => { - writeResults(tokens, PATHS_.BASE_TOKENS_JS, 'js') + writeResults(tokens, PATHS_.BASE_TOKENS_JS, 'ts') const baseIndexContent = `${tokens .map((token) => `import { ${token.name} } from './${token.name}'`) @@ -32,7 +32,7 @@ const writeJSTokens = (tokens) => { } ` - writeFile(PATHS_.BASE_TOKENS_JS, 'index', 'js', baseIndexContent) + writeFile(PATHS_.BASE_TOKENS_JS, 'index', 'ts', baseIndexContent) // Disabled – shouldn’t really be done here… // writeFile(`${TOKENS_DIR}`, 'index', 'js', `export { tokens } from './base'`) diff --git a/libraries/tokens/base/clickbounds.js b/libraries/tokens/base/clickbounds.ts similarity index 100% rename from libraries/tokens/base/clickbounds.js rename to libraries/tokens/base/clickbounds.ts diff --git a/libraries/tokens/base/colors.js b/libraries/tokens/base/colors.ts similarity index 100% rename from libraries/tokens/base/colors.js rename to libraries/tokens/base/colors.ts diff --git a/libraries/tokens/base/elevation.js b/libraries/tokens/base/elevation.ts similarity index 100% rename from libraries/tokens/base/elevation.js rename to libraries/tokens/base/elevation.ts diff --git a/libraries/tokens/base/index.js b/libraries/tokens/base/index.ts similarity index 100% rename from libraries/tokens/base/index.js rename to libraries/tokens/base/index.ts diff --git a/libraries/tokens/base/shape.js b/libraries/tokens/base/shape.ts similarity index 100% rename from libraries/tokens/base/shape.js rename to libraries/tokens/base/shape.ts diff --git a/libraries/tokens/base/spacings.js b/libraries/tokens/base/spacings.ts similarity index 100% rename from libraries/tokens/base/spacings.js rename to libraries/tokens/base/spacings.ts diff --git a/libraries/tokens/base/typography.js b/libraries/tokens/base/typography.ts similarity index 100% rename from libraries/tokens/base/typography.js rename to libraries/tokens/base/typography.ts diff --git a/libraries/tokens/index.js b/libraries/tokens/index.ts similarity index 100% rename from libraries/tokens/index.js rename to libraries/tokens/index.ts diff --git a/libraries/tokens/package.json b/libraries/tokens/package.json index 18ebdb1c91..36bfe445a2 100644 --- a/libraries/tokens/package.json +++ b/libraries/tokens/package.json @@ -37,7 +37,8 @@ ], "devDependencies": { "@rollup/plugin-node-resolve": "^8.0.1", - "rollup": "^2.15.0" + "rollup": "^2.15.0", + "typescript": "^4.0.2" }, "engines": { "pnpm": ">=4", diff --git a/libraries/tokens/pnpm-lock.yaml b/libraries/tokens/pnpm-lock.yaml index 623c92e6ee..d5d3f2d2ec 100644 --- a/libraries/tokens/pnpm-lock.yaml +++ b/libraries/tokens/pnpm-lock.yaml @@ -1,6 +1,7 @@ devDependencies: '@rollup/plugin-node-resolve': 8.0.1_rollup@2.15.0 rollup: 2.15.0 + typescript: 4.0.2 lockfileVersion: 5.1 packages: /@rollup/plugin-node-resolve/8.0.1_rollup@2.15.0: @@ -105,6 +106,14 @@ packages: fsevents: 2.1.3 resolution: integrity: sha512-HAk4kyXiV5sdNDnbKWk5zBPnkX/DAgx09Kbp8rRIRDVsTUVN3vnSowR7ZHkV6/lAiE6c2TQ8HtYb72aCPGW4Jw== + /typescript/4.0.2: + dev: true + engines: + node: '>=4.2.0' + hasBin: true + resolution: + integrity: sha512-e4ERvRV2wb+rRZ/IQeb3jm2VxBsirQLpQhdxplZ2MEzGvDkkMmPglecnNDfSUBivMjP93vRbngYYDQqQ/78bcQ== specifiers: '@rollup/plugin-node-resolve': ^8.0.1 rollup: ^2.15.0 + typescript: ^4.0.2