Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tab claims that parameter groups with all CONST are being localized, i.e., updated #7074

Open
dafeda opened this issue Feb 1, 2024 · 3 comments
Assignees

Comments

@dafeda
Copy link
Contributor

dafeda commented Feb 1, 2024

To reproduce
Steps to reproduce the behaviour:

  1. Add new GEN_KW to poly.ert with all CONST.
    For example: GEN_KW COEFFS_CONST coeff_priors_const where the file coeff_priors_const contains:
a CONST 0
b CONST 2
c CONST 5
  1. Run Ensemble smoother with Adaptive Localization which results in this screenshot:

image

Expected behaviour
Make it clear to users that we are not updating const-parameters.

@oyvindeide
Copy link
Collaborator

This is intended behavior, so removing the bug label, have added documentation to how one can avoid updating parameters.

@oyvindeide oyvindeide removed the bug label Mar 8, 2024
@oyvindeide
Copy link
Collaborator

Note quite sure what to do with this issue, as it is intended behavior, and the parameters are updated, but still show up as constant for the user. There is no system to allow for not updating single parameters, only parameter groups. So in this particular example the user could add: UPDATE:FALSE, but if one of the parameters were not CONST, that would not work. We could of course add the option of providing UPDATE:FALSE to individual parameters, but that would be quite a bit more work.

@oyvindeide
Copy link
Collaborator

So after discussion the solution here is to introduce an UPDATE:TRUE/FALSE flag to individual parameters (as opposed to parameter groups which already exists). If the parameter is CONST, this flag should always be FALSE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

2 participants