Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upDark theme dropdown is difficult to read when using 'Revert Dark Theme' CSS #433
Comments
This comment has been minimized.
This comment has been minimized.
Also having this bug. Editing the CSS in the inspector temporarily fixes it as @EvilJackCarver said, but putting the same snippet into the custom CSS does nothing. I tried editing other things in the custom CSS too and it seems like the dark revert stylesheet might be overwriting the changes in custom CSS. Edit: I did some more testing and it seems like that's what's happening. When I overwrite something that's not edited by the dark theme revert, like changing the usernames to red for example, it works fine. But when overwriting something that is edited by it, the changes flash for a second and then revert. See this GIF showing this where I edited column headers to have a red background color: |
This comment has been minimized.
This comment has been minimized.
I was able to fix this for myself with the snippet below in custom css. Tested on FireFox. /* fix text color */
htm.dark .dropdown-menu .non-selectable-item
, html.dark .dropdown-menu .js-dropdown-content a:not(:hover):not(:focus)
, html.dark .dropdown-menu .js-dropdown-content .non-selectable-item { color: #e1e8ed; }
/* fix background color */
html.dark .dropdown-menu { background-color: #292F33; } |
The dropdown menus on tweets are very difficult to read when using night-mode with the 'revert dark theme' CSS tweak. The
color
key in revert-dark-theme.css is set to#292F33
.I was able to correct this (temporarily) by going into the element inspector and editing
html.dark .dropdown-menu a:not(:hover):not(:focus)
to#fff
(the element inspector says that's line 517 of revert-dark-theme.css). However, I'm not proficient enough in CSS to be confident in putting that tweak in my Custom CSS slot.The text is legible when highlighted.