New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove media link only when it ends the tweet #97

Closed
babolivier opened this Issue Sep 12, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@babolivier
Contributor

babolivier commented Sep 12, 2016

Hey hey,

I think it'd be nicer to remove a media's link in a tweet only if this link is placed at the end of the tweet. Otherwise, we can have cases like:

Hey, I like what you did, but I was thinking more of something like: . What do you think about that?

If the person I'm talking to uses BTD, s.he won't necessarily link that missing something after "like:" with the media displayed below. Of course, this doesn't happen if the link ends the tweet, as the embed media "replaces" its link.

This case actually just happened to me as I'm discussing (using DMs) a flyer for one of my non-profit's events with our graphic artist, and I sent him a JPG image to give him a hint on my expectations.

Thoughts?

@eramdam

This comment has been minimized.

Owner

eramdam commented Sep 12, 2016

Makes total sense.

PS: you can use they instead of s.he, it's as neutral and it's easier 😜

@eramdam eramdam added the enhancement label Sep 12, 2016

@eramdam eramdam self-assigned this Sep 12, 2016

@eramdam

This comment has been minimized.

Owner

eramdam commented Sep 12, 2016

The only tricky part is to determine when the link indeed ends the tweet...

@eramdam eramdam closed this in cd9ad2b Sep 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment