Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd feature to collapse read direct messages #105
Conversation
eramdam
merged commit 16c6012
into
eramdam:master
Nov 17, 2016
This comment has been minimized.
This comment has been minimized.
jaydenkieran
commented
Nov 21, 2016
|
Just wanted to say, this is such a nice (albeit simple) feature. Cheers for adding it in. Makes reading DMs so much easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
pixeldesu commentedNov 17, 2016
This feature adds the ability to collapse read direct messages, meaning only unread direct messages will have their full text (or preview) displayed.
The styling and positioning of the usernames and dates might look a bit off, but considering there might be changes to it very often over time it is more effort to keep the positioning accurate based on magic numbers than just keeping it the way it is, it's not off too much off anyway and people adjust to change rather quickly.