Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support of Nicoseiga #120

Merged
merged 6 commits into from Feb 6, 2017
Merged

Conversation

@shuuji3
Copy link
Contributor

@shuuji3 shuuji3 commented Jan 24, 2017

Nico Nico Seiga (Nicoseiga) is a well-known Japanese illustration community provided by Nicovideo.

Now we've covered, I think, almost all the popular Japanese illustration communities. 馃槅

shuuji3 added 5 commits Jan 21, 2017
[TINAMI](https://tinami.com) is one of famous Japanese illustration community for fans of anime and comics like Pixiv.
[Nico nico seiga (Nicoseiga)](http://seiga.nicovideo.jp) is a well-known Japanese illustration community provided by Nicovideo.
@shuuji3
Copy link
Contributor Author

@shuuji3 shuuji3 commented Jan 24, 2017

I fixed some lint errors Travis CI said, but no-underscore-dangle errors remain. This is because xml-js's Compact JSON requires _ for its attribute name.

@shuuji3 shuuji3 changed the title Add thumbnail nicoseiga add support of Nicoseiga Jan 24, 2017
@eramdam eramdam merged commit e606419 into eramdam:master Feb 6, 2017
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@eramdam
Copy link
Owner

@eramdam eramdam commented Feb 6, 2017

Do you have sample URLs that I could keep for testing?

@shuuji3
Copy link
Contributor Author

@shuuji3 shuuji3 commented Feb 6, 2017

Sorry, I forgot that. Here are some URLs:

http://seiga.nicovideo.jp/seiga/im5971169
http://seiga.nicovideo.jp/seiga/im3332285
http://nico.ms/im4501479

or, you can find URLs by searching #nicoseiga in the Twitter search.

@shuuji3 shuuji3 deleted the shuuji3:add-thumbnail-nicoseiga branch Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can鈥檛 perform that action at this time.