Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of Google+ photo album #126

merged 3 commits into from Mar 13, 2017


type: 'image',
thumbnail_url: $.getSafeURL(thumbnailUrl),
url: $.getSafeURL(imgUrl),

This comment has been minimized.


eramdam Mar 9, 2017

Same comment as on the worldCosplay PR. You're supposed to simply return the object.

@@ -19,6 +19,7 @@ const endpoints = {
pixiv: '',
tinami: '',
nicoseiga: '',
googleplus: '',

This comment has been minimized.


eramdam Mar 9, 2017

Could you add this endpoint to tools/manifests/common.js in the permissions field as well?

@eramdam eramdam dismissed their stale review Mar 13, 2017

Gonna do the changes myself

@eramdam eramdam merged commit c013cc1 into eramdam:master Mar 13, 2017
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
@shuuji3 shuuji3 deleted the shuuji3:add-thumbnail-google-plus branch Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants