New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of WorldCosplay #127

Merged
merged 3 commits into from Mar 13, 2017

Conversation

Projects
None yet
2 participants
@shuuji3
Contributor

shuuji3 commented Feb 13, 2017

WorldCosplay is one of the most popular cosplay community.

Test URLs:

Note: Instants photo expires in 3 days. You can find new one here:
https://worldcosplay.net/instants

shuuji3 added some commits Feb 13, 2017

add support of WorldCosplay
[WorldCosplay](https://worldcosplay.net/) is one of the most popular cosplay community.
} else {
return undefined;
}

This comment has been minimized.

@eramdam

eramdam Mar 9, 2017

Owner

That's a good candidate for a switch statement. It would make the code easier to read

thumbnail_url: $.getSafeURL(thumbnailUrl),
url: $.getSafeURL(imgUrl),
});
});

This comment has been minimized.

@eramdam

eramdam Mar 9, 2017

Owner

You're supposed to simply return the object here instead of a Promise.resolve() instance.

@eramdam eramdam merged commit f206945 into eramdam:master Mar 13, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@shuuji3 shuuji3 deleted the shuuji3:add-thumbnail-worldcosplay branch Oct 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment