Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new TweetDeck official icon-set for BTD icons #167

Merged
merged 3 commits into from Jun 15, 2017
Merged

Use the new TweetDeck official icon-set for BTD icons #167

merged 3 commits into from Jun 15, 2017

Conversation

@LeoColomb
Copy link
Contributor

@LeoColomb LeoColomb commented Jun 15, 2017

馃寛

@eramdam
Copy link
Owner

@eramdam eramdam commented Jun 15, 2017

@LeoColomb can I see a screenshot of the emoji/poll thing?

@LeoColomb
Copy link
Contributor Author

@LeoColomb LeoColomb commented Jun 15, 2017

Icon Before After
Emoji image image
Poll image image
@eramdam
Copy link
Owner

@eramdam eramdam commented Jun 15, 2017

The emoji is 馃憣 but the poll icon is less legible now. I would keep the old poll icon but use the new emoji icon.

@LeoColomb
Copy link
Contributor Author

@LeoColomb LeoColomb commented Jun 15, 2017

the poll icon is less legible now

What do you mean? 馃樃

@eramdam
Copy link
Owner

@eramdam eramdam commented Jun 15, 2017

@LeoColomb it's messier than before, I don't think the stroke icons are meant to be displayed at such a small size

@LeoColomb
Copy link
Contributor Author

@LeoColomb LeoColomb commented Jun 15, 2017

But on the other hand it's the new official Twitter icon/design for poll relative buttons...

image

@eramdam
Copy link
Owner

@eramdam eramdam commented Jun 15, 2017

Let's merge it and I'll see how it goes.

@eramdam eramdam merged commit 6a38581 into eramdam:master Jun 15, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@LeoColomb
Copy link
Contributor Author

@LeoColomb LeoColomb commented Jun 15, 2017

As you want! 馃槃

@LeoColomb
Copy link
Contributor Author

@LeoColomb LeoColomb commented Jun 21, 2017

I'll see how it goes.

Well, no more necessary! 馃槅

In fact poll button addition should be removed...
image

@eramdam
Copy link
Owner

@eramdam eramdam commented Jun 21, 2017

I already pushed a commit for that. I still have to do a release 馃槄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants