/BetterTweetDeck

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hiding columns from the column header. #208

Merged
merged 13 commits into from Sep 16, 2017

Conversation

Reviewers

@eramdam eramdam

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
2 participants
@EntranceJew @eramdam
@EntranceJew
Contributor

EntranceJew commented Aug 28, 2017 •
edited

Hide a column by clicking on - a lot.
Restore a column by clicking on it in the left column navigator.

notes:

  • needs more work
  • keyboard navigation 1-9 seems to work weirdly.
  • if you minimize a column in the front, pressing 1 will take you
    to the new first available column
  • if you minimize a column in the 4th position then it will
    absorb keypresses as if it is still there
  • the column heads show numbers, these are from CSS, therefore hiding
    a column makes the styles skip numbers making it appear as if they
    do not exist anywhere but the left navigation
  • lots of styles could probably be shaved out but i'm bad at everything

not tested columns:

  • any 'temporary' column (whatever those are)
  • columns with long titles and/or usernames
  • searches / trending / editable column titles

tested columns:

  • home
  • collections
  • notifications
  • messages / all messages
  • likes
  • mentions / all mentions
  • followers
  • activity
  • scheduled (seems good?)

@EntranceJew EntranceJew force-pushed the EntranceJew:feature/hide-columns branch from 3c105b4 to 11f82d1 Aug 28, 2017

@eramdam eramdam added the in-progress label Aug 28, 2017

@eramdam eramdam changed the title from :cookie: Added hiding columns from the column header. to Added hiding columns from the column header. Aug 28, 2017

@EntranceJew EntranceJew force-pushed the EntranceJew:feature/hide-columns branch 6 times, most recently from cf4e650 to d6e2ba9 Aug 31, 2017

EntranceJew added some commits Aug 28, 2017

@EntranceJew
🍪 Added hiding columns from the column header. 
Hide a column by clicking on `-` a lot.
Restore a column by clicking on it in the left column navigator.

notes:

 * keyboard navigation `1-9` seems to work weirdly.
  * if you minimize a column in the front, pressing `1` will take you
    to the _new_ first available column
  * if you minimize a column in the 4th position then it will
    absorb keypresses as if it is still there
 * the column heads show numbers, these are from CSS, therefore hiding
   a column makes the styles skip numbers making it appear as if they
   do not exist anywhere but the left navigation
 * lots of styles could probably be shaved out but i'm bad at everything

not tested columns:

 * any 'temporary' column (whatever those are)
 * columns with long titles and/or usernames
 * searches / trending / editable column titles

tested columns:

 * home
 * collections
 * notifications
 * messages / all messages
 * likes
 * mentions / all mentions
 * followers
 * activity
 * scheduled (seems good?)
6b72a14
@EntranceJew
📝 Collapse columns instead of disappearing them.
bafab41
@EntranceJew
📝 Collapsed columns toggle and persist.
0cd77a5
@EntranceJew
📝 Extend TD.vo.Column's constructor to namespace our extensions.
da7f4a8
@EntranceJew
Renamed things to match collapsing columns, css file, now optional
91dff7a
@EntranceJew
Changed the timing of settingsReady and honored the option.
391c36b
@EntranceJew
Un-inverted settings checks, click listeners use body now.
4996946
@EntranceJew
Switched to mousedown, removed debug prints.
29e350f
@EntranceJew
Flexing on the haters.
a7c7bf2
@EntranceJew
Added messages that I swear were already here.
b7b68e3
@EntranceJew
Fixed issue w/ TD.vo.Column patch breaking searches.
0abd6a9
@EntranceJew
Expanding a column will now showColumn so you can see it.
15f2653
@EntranceJew
Forgot to set default option. It's here now!
Loading status checks…
9bb2d65

@EntranceJew EntranceJew force-pushed the EntranceJew:feature/hide-columns branch from d6e2ba9 to 9bb2d65 Sep 15, 2017

@eramdam eramdam added feature and removed in-progress labels Sep 15, 2017

@eramdam

eramdam approved these changes Sep 16, 2017
View changes

@eramdam eramdam merged commit 52081bc into eramdam:master Sep 16, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EntranceJew EntranceJew deleted the EntranceJew:feature/hide-columns branch Sep 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment