Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp templates to the download filename #442

Merged
merged 7 commits into from Nov 29, 2019

Conversation

@shuuji3
Copy link
Contributor

shuuji3 commented Sep 22, 2019

What

This PR adds timestamp templates to the download filename and enables to embed the date and time of the tweet into the filename strings.

The introduced templates are following:
year, month, day, hours, minutes, and secods.

Also, the default template is changed to include the date and time.

Why

This fixes #414.

The date and time can be determined from the tweet ID unless the tweet is deleted. However, as the comment on #414 says, it's better to include tweet date for the archiving purpose.

@shuuji3 shuuji3 force-pushed the shuuji3:add-timestamp-to-download-filename branch from f32cb8a to 3e6e847 Sep 22, 2019
eramdam added 3 commits Oct 12, 2019
@eramdam eramdam merged commit 9523607 into eramdam:master Nov 29, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@shuuji3 shuuji3 deleted the shuuji3:add-timestamp-to-download-filename branch Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.